-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add TeamCity build script for post-merge algolia index updation #19315
base: main
Are you sure you want to change the base?
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a comment on a minor style choice from the old script, that we could change here - or leave as-is, to avoid any delay.
exit 1 | ||
fi | ||
|
||
ALGOLIA_API_KEY=${PROD_ALGOLIA_API_KEY} ALGOLIA_LOG_LEVEL=debug bundle exec jekyll algolia --config _config_base.yml,_config_url.yml --builds-config _config_cockroachdb.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, re. this line inherited from the old script.
For better readability, we could have the key and log level assignment on their own lines. (No downside in allowing them to persist for the 'rest of the script', as this is essentially the end of the script.)
Please feel free to merge as-is, though!
Summary
This PR introduces a TeamCity build script that automates post-merge tasks for the main branch of the
docs
repository. The script performs the following steps:Why This Change Is Needed
This is being done to decouple it from the netlify build
Notes
PROD_ALGOLIA_API_KEY
environment variable to be set in the build environment.Internal / Cockroach / Post Merge / Docs
TeamCity project.Testing