Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL-1722 v25.1.0-beta.1: [Docs] Generate Release notes for download/SH #19314

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Jan 17, 2025

Fixes REL-1722

edited release notes
In versions.csv, or v25.1 set crdb_branch_name to release-24.3 so that sql-grammar page does not have a 404 error.

Copy link

Files changed:

  • src/current/_data/releases.yml
  • src/current/_data/versions.csv
  • src/current/_includes/releases/v25.1/v25.1.0-beta.1.md:

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 1e83e89
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6791804552323a00080763d6

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 1e83e89
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67918045710cc00008a61eba

Copy link

netlify bot commented Jan 17, 2025

Netlify Preview

Name Link
🔨 Latest commit 1e83e89
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67918045bc46100008b6ed74
😎 Deploy Preview https://deploy-preview-19314--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…that sql-grammar page does not have a 404 error.
@florence-crl florence-crl requested review from taroface and removed request for kathancox January 17, 2025 18:56
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some minor suggestions.

src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tftr!

src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
src/current/_includes/releases/v25.1/v25.1.0-beta.1.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit ac7f95c into main Jan 23, 2025
6 checks passed
@florence-crl florence-crl deleted the v25.1.0-beta.1 branch January 23, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants