Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VECTOR doc #18791

Merged
merged 4 commits into from
Aug 8, 2024
Merged

add VECTOR doc #18791

merged 4 commits into from
Aug 8, 2024

Conversation

taroface
Copy link
Contributor

@taroface taroface commented Aug 6, 2024

Copy link

github-actions bot commented Aug 6, 2024

Files changed:

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit da1fea6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66b5157a7d5e860008fec6db

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit da1fea6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66b5157a3ffc7100088d3349

Copy link

netlify bot commented Aug 6, 2024

Netlify Preview

Name Link
🔨 Latest commit da1fea6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66b5157ae13e2100082ded11
😎 Deploy Preview https://deploy-preview-18791--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jordanlewis
Copy link
Member

This looks correct from an Engineering perspective. Perhaps @mgartner would want to weigh in as well.

From the product perspective, I think we should consider adding some more exposition about how to use the feature for a simple embedding search with common data, such as embeddings from OpenAI. But I will let @dikshant weigh in on that.

@dikshant
Copy link

dikshant commented Aug 7, 2024

I think we should consider adding some more exposition about how to use the feature for a simple embedding search with common data, such as embeddings from OpenAI

We will cover some of this in an upcoming blog post (targeted for mid September) and we can update the docs then. We can go ahead with this PR for now.

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taroface taroface requested a review from florence-crl August 7, 2024 18:16
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending adding enterprise note

src/current/v24.2/vector.md Show resolved Hide resolved
@taroface taroface enabled auto-merge (squash) August 8, 2024 18:58
@taroface taroface merged commit 5808e14 into main Aug 8, 2024
6 checks passed
@taroface taroface deleted the pgvector branch August 8, 2024 19:09
mdlinville pushed a commit that referenced this pull request Aug 9, 2024
* add VECTOR doc
mdlinville pushed a commit that referenced this pull request Aug 12, 2024
* add VECTOR doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants