testing final - #3
Open
CesarDav wants to merge 1 commit into
Open
Conversation
alacret
requested changes
Jul 13, 2019
|
|
||
| //stripe | ||
| createPaymentRequest({data}) | ||
| _sendEmail({data}) |
Contributor
There was a problem hiding this comment.
Suggested change
| _sendEmail({data}) | |
| await _sendEmail({data}) |
| } | ||
|
|
||
| // googledrive folder | ||
| await admin.firestore().collection('payments').doc(basicInformation.email).set({payamentData}) |
Contributor
There was a problem hiding this comment.
Cambia esto, deja que el ID lo autogenere firebase con .add, y coloca el email y la fecha como un campo mas, asi como lo tienes cada vez que vamos a escribir un payment nuevo hay que borrar el viejo
| try { | ||
| let status = await stripe.charges.create({ | ||
| amount: 1500, | ||
| amount: 1, |
Contributor
There was a problem hiding this comment.
Esta valor no esta permitido por la API. @CesarDav acostumbrate por favor a leerte la documentacion para poder trabajar bien. Si te lees la documentacion de este metodo en Stripe te dice claramente cuales son los valores permitidos:
https://stripe.com/docs/api/charges/object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.