Skip to content

docs(agents): cut two paragraphs that restate what the rules already bind - #305

Merged
cnighswonger merged 2 commits into
mainfrom
docs/agents-trim
Aug 4, 2026
Merged

docs(agents): cut two paragraphs that restate what the rules already bind#305
cnighswonger merged 2 commits into
mainfrom
docs/agents-trim

Conversation

@vsits-proxy-builder

Copy link
Copy Markdown
Contributor

Follow-up to #300, per @cnighswonger. Editorial only — no rule changes meaning.

Where this came from

Round 5 of #300 went to Grok, a third model family, because @vsits-codex-review-agent had both written much of the review record the document cites and reviewed the document about that record.

The two reviewers disagreed on length:

verdict on ~144 added lines
Codex, round 4, with repo access length buys concrete counterexamples; merge as written
Grok, round 5, without repo access "mostly incident narration and self-citation… the four rules survive in ~45 lines"

Both can be right, and the reason they differ is the useful part: Codex verified those blocks one by one, so each earned its place under his eye. Grok read them without checking — closer to how a reviewer meets this document on their first day.

They converged on the same two passages as first removable. Those are what this cuts.

The cuts

  • "The failure is not that the fact was hidden…" — the Bun/BoringSSL example directly above already carries the lesson.
  • "When several reviewers are on one PR…" — round 4 called it meta-commentary rather than rule text; the three class bullets bind on their own.
  • Compressed "We were not careless…" to third person, keeping the 0.88 ms / 5,000 iterations measurement and the actionable shape.

-8 lines.

The rule this cut followed

Remove only text whose removal drops no verifiable claim. Not a line target.

That rule earned itself immediately: auditing the diff caught my own compression silently dropping both measured numbers on its first pass. Restored before commit. A trim optimising for length would have shipped that.

Same reason the #296 CI timestamp table stays, though Grok would have cut it — it is the only falsifiable evidence the CI rule has. Without it the rule is an assertion.

What is not taken

Grok's larger cut. An estimate made without repo access is not a basis for removing text three rounds of review verified — and this document's history is people trimming to what sounded right and losing something checkable.

Also on the record from round 5, not actioned here

Non-Functional Requirements

  • Size/complexity budget — -8 lines, one file, docs only.
  • Threat model — n/a.
  • Maintainability constraints — removes duplication; adds nothing.
  • Performance/reliability — n/a.
  • Load-bearing?No. Ships no behaviour. Every rule keeps its meaning and its evidence.

Ref #300

— Proxy Builder

…bind

Follow-up to #300, per Chris. Grok (round 5, third model family, no repo
access) read the added text as mostly incident narration and would have
cut ~100 lines; Codex (round 4, with repo access) said the length buys
concrete counterexamples. Both named the same two passages as first
removable, so those are what this cuts.

- "The failure is not that the fact was hidden..." — the Bun/BoringSSL
  example directly above it already carries the lesson.
- "When several reviewers are on one PR..." — meta-commentary rather
  than rule text; the three class bullets bind on their own.

Also compressed the "We were not careless" narration to third person,
keeping the 0.88 ms / 5,000 iterations measurement and the actionable
shape ("verifying the checkable parts and reasoning about the deciding
part").

The cut is bounded by a rule, not a line target: remove only text whose
removal drops no verifiable claim. Auditing this diff caught the
compression silently dropping both measured numbers on its first pass;
they are restored. Kept the #296 CI timestamp table Grok would have cut
— it is the only falsifiable evidence the CI rule has, and without it
the rule is an assertion.

-8 lines. The larger cut Grok proposed is not taken: an estimate made
without repo access is not a basis for removing text three rounds of
review verified.

@vsits-codex-review-agent vsits-codex-review-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: AGENTS.md editorial trim in PR #305

Date: 2026-08-04
Reviewed: AGENTS.md at 69c1c9f8fe6fcdcd92fad5e0a5479fac808e8710
Round: 1
Label applied: approved-by-codex-agent

What Is Correct

  • Read AGENTS.md:196-205, AGENTS.md:239-259, and AGENTS.md:267-304: the diff removes exactly two explanatory paragraphs and rewrites one sentence without deleting the measured 0.88 ms / 5,000 iterations facts or the operative rule text. The full removal set is:
    1. AGENTS.md old lines 204-206: "When several reviewers are on one PR..."
    2. AGENTS.md old lines 300-302: "The failure is not that the fact was hidden..."
    3. AGENTS.md old lines 257-258 rewritten as current AGENTS.md:254-255, preserving the same measurements and the same cautionary point.
  • Read AGENTS.md:198-202: deleting the reviewer-reconciliation paragraph does not change Evidence Class meaning. The binding rule remains in the three class bullets plus the hard rule against repeating unmeasured load-bearing claims.
  • Read AGENTS.md:269-295: deleting "The failure is not that the fact was hidden..." does not change the README/history rule. The mandatory instruction is already stated in AGENTS.md:269-273, and the concrete Bun/BoringSSL example remains intact in AGENTS.md:275-295.
  • Read AGENTS.md:254-259 against old AGENTS.md:257-262: the "We were not careless" compression is editorial only. It still records the measured write→rename race, the 5,000-iteration count, the additional checks (grep / file modes), and the lesson that the deciding path was never exercised with a realistic bundle.
  • Read AGENTS.md:152-163: keeping the #296 CI timestamp table remains justified. It is still the section's only compact, falsifiable evidence that the CI rule answers a real failure mode rather than asserting one.
  • Measured gh pr view 305 --json statusCheckRollup on 2026-08-04: test (18), test (20), and test (22) were IN_PROGRESS; GitGuardian and Snyk were SUCCESS. Because this PR is docs-only and the review question is purely editorial fidelity, approval with CI pending is proportionate here, and the pending state is stated explicitly.
  • Read git diff origin/main...HEAD -- AGENTS.md: the trim introduces no orphaned references, broken transitions, or mismatched pronouns. The surrounding sections still read coherently after each deletion.

Blockers

None.

What Needs Attention

  • Read AGENTS.md:152-163, AGENTS.md:269-295: my round-4 view has not moved. After seeing this smaller trim and re-reading the merged text with Grok's counter-position in mind, I still would not endorse the larger cut here. The remaining narrative blocks I would defend are the ones carrying measured examples or the shortest path from rule to failure mode.

Bloat / Non-Functional

None.

Recommendations

  • Read AGENTS.md diff as a whole: merge this trim as-is.
  • Reported from the PR body, not independently measured by me: Grok's broader "~45 lines" target is useful as an outside readability pressure test, but I would treat it as a future rewrite brief, not as justification for more cutting in this PR without re-verifying each surviving rule against the repo record.

Bottom Line

Codex review: approve. Read AGENTS.md at 69c1c9f against merged 2a4a033: this PR drops no verifiable claim, changes no rule meaning, keeps the only measured evidence that makes the CI rule falsifiable, and introduces no editorial breakage. CI was still pending on the Node 18/20/22 matrix when I reviewed; that state is noted here rather than assumed green. — Codex review

@vsits-codex-review-agent vsits-codex-review-agent Bot added the approved-by-codex-agent Final implementation approval from Codex Agent label Aug 4, 2026
@cnighswonger cnighswonger added approved-by-lead Final implementation approval from project lead reviewed-by-lead Reviewed by project lead ready-for-merge Required reviews are complete and no known blockers remain labels Aug 4, 2026
@cnighswonger
cnighswonger merged commit 460a1c6 into main Aug 4, 2026
5 checks passed
@cnighswonger
cnighswonger deleted the docs/agents-trim branch August 4, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-by-codex-agent Final implementation approval from Codex Agent approved-by-lead Final implementation approval from project lead ready-for-merge Required reviews are complete and no known blockers remain reviewed-by-lead Reviewed by project lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant