Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding resources page #42

Merged
merged 1 commit into from
Aug 17, 2020
Merged

adding resources page #42

merged 1 commit into from
Aug 17, 2020

Conversation

parispittman
Copy link
Contributor

#3 and #15

@parispittman parispittman force-pushed the resources branch 3 times, most recently from d5f444b to 9ecb4f5 Compare July 29, 2020 07:12
idvoretskyi
idvoretskyi reviewed Jul 29, 2020
View reviewed changes
resources.md Outdated Show resolved Hide resolved
saad-ali
saad-ali approved these changes Jul 29, 2020
View reviewed changes
Copy link

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

iennae
iennae reviewed Jul 29, 2020
View reviewed changes
resources.md Outdated Show resolved Hide resolved
iennae
iennae reviewed Jul 29, 2020
View reviewed changes
resources.md Outdated Show resolved Hide resolved
geekygirldawn
geekygirldawn requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@geekygirldawn geekygirldawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! My comments are mostly nits, but I'd like to see this scrubbed for consistent capitalization. I made a few comments, but noticed similar issues in the rest of doc, and didn't want to seem like the Grammar Police by calling out each one :)

resources.md Outdated Show resolved Hide resolved
resources.md Outdated Show resolved Hide resolved
resources.md Show resolved Hide resolved
@justaugustus
Copy link
Contributor

I had doc nits, but it looks like they're sorted with the new push.
Will give a review before the week is out.

@jberkus
Copy link
Contributor

jberkus commented Aug 13, 2020

/lgtm

@justaugustus
Copy link
Contributor

/lgtm

@justaugustus justaugustus merged commit d476413 into cncf:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi left review comments

@iennae iennae iennae left review comments

@geekygirldawn geekygirldawn geekygirldawn requested changes

@saad-ali saad-ali saad-ali approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@jberkus jberkus Awaiting requested review from jberkus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@parispittman @justaugustus @jberkus @idvoretskyi @geekygirldawn @iennae @saad-ali