Disallow setting more threads that number of CPU cores available [wip]

Signed-off-by: Lukasz Gryglicki <[email protected]>
cncf · Nov 6, 2019 · 3cb7534 · 3cb7534
1 parent 27058a1
commit 3cb7534
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/threads.go b/threads.go
@@ -11,6 +11,10 @@ import (
 func GetThreadsNum(ctx *Ctx) int {
 	// Use environment variable to have singlethreaded version
 	if ctx.NCPUs > 0 {
+		n := runtime.NumCPU()
+		if ctx.NCPUs > n {
+			ctx.NCPUs = n
+		}
 		runtime.GOMAXPROCS(ctx.NCPUs)
 		return ctx.NCPUs
 	}

diff --git a/threads_test.go b/threads_test.go
@@ -29,6 +29,7 @@ func TestGetThreadsNum(t *testing.T) {
 		{ST: true, NCPUs: 1, expected: 1},
 		{ST: true, NCPUs: -1, expected: 1},
 		{ST: true, NCPUs: 2, expected: 2},
+		{ST: true, NCPUs: nThreads + 1, expected: nThreads},
 	}
 	// Execute test cases
 	for index, test := range testCases {