This repository was archived by the owner on May 3, 2022. It is now read-only.
Fix not installing when invocation image not present #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Failing linter errors should be solved by #612. I think? |
michelleN
reviewed
Feb 7, 2019
There was a problem hiding this comment.
@radu-matei would you mind rebasing? I fixed those import errors at some point I think
radu-matei
force-pushed
the
fix-596-pull-invocation-image
branch
from
23d16b5 to
80608b8
Compare
|
@michelleN - rebased. |
michelleN
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian at least, it turns out we are hitting Nvveen/Gotty#1 - workaround is to pass
isTerm = falsetojsonmessage.DisplayJSONMessagesStream().closes #596