Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss airgapped environments #370

Merged

Conversation

trishankatdatadog
Copy link
Member

To resolve one issue in #369

Signed-off-by: Trishank Karthik Kuppusamy [email protected]

300-CNAB-security.md Outdated Show resolved Hide resolved
805-airgap.md Outdated Show resolved Hide resolved
805-airgap.md Outdated Show resolved Hide resolved
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few very small nits, but otherwise LGTM.

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One link needs attention, otherwise LGTM.

805-airgap.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the fixes mentioned by @radu-matei and @vdice

@trishankatdatadog trishankatdatadog mentioned this pull request Jun 17, 2020
5 tasks
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/airgap-cnab-sec branch from c21dacb to 340a3c1 Compare June 17, 2020 16:15
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/airgap-cnab-sec branch from 340a3c1 to b19fd85 Compare June 19, 2020 02:18
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radu-matei radu-matei merged commit 228f37d into cnabio:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants