Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #280 from trishankatdatadog/trishankatdatadog/add-verification-workflows #280

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Merge pull request #280 from trishankatdatadog/trishankatdatadog/add-verification-workflows #280

merged 7 commits into from
Jan 28, 2020

Conversation

trishankatdatadog
Copy link
Member

@trishankatdatadog trishankatdatadog commented Sep 16, 2019 •
edited
Loading

Part of #253

Major TODOs:

  • Go into a bit more detail
  • Describe thick bundles
  • Explain that it doesn't matter where you store bundles or metadata, or whether it's a think or thick bundle, because verification would exactly the same
  • Radu: will work on known implementations

@trishankatdatadog trishankatdatadog mentioned this pull request Sep 16, 2019
Merged
9 tasks
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/add-verification-workflows branch from e1b7b7b to 89d28c5 Compare September 16, 2019 18:49
@radu-matei radu-matei mentioned this pull request Oct 22, 2019
Merged
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/add-verification-workflows branch from db45599 to 8237a09 Compare December 17, 2019 20:00
vdice
vdice reviewed Dec 23, 2019
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads very well; LGTM. One minor update needed.

303-verification-workflows.md Show resolved Hide resolved
technosophos
technosophos approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technosophos
Copy link
Member

DCO just needs an append with a --signoff. Then we should merge this as a draft.

radu-matei
radu-matei approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the DCO is signed, LGTM.
Thanks a lot for the effort, Trishank!

trishankatdatadog and others added 7 commits January 28, 2020 11:29
@trishankatdatadog
WIP on verification workflows
e70b251 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
Add initial verification workflow for CNAB Security
07167df 
Signed-off-by: Radu M <[email protected]>
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
wrap up verification workflow
fe435ba 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
remove gitignore
b92ace4 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
address @radu-matei feedback
269380b 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
add a note about different servers
a24c0aa 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
address @vdice feedback
fa8026b 
Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/add-verification-workflows branch from 3a39fad to fa8026b Compare January 28, 2020 16:29
@trishankatdatadog
Copy link
Member Author

DCO is signed. Thanks, everyone! 🙇

@radu-matei radu-matei changed the title CNAB Security 303: Verification workflows Merge pull request #280 from trishankatdatadog/trishankatdatadog/add-verification-workflows Jan 28, 2020
@radu-matei radu-matei merged commit 88949d0 into cnabio:master Jan 28, 2020
@trishankatdatadog trishankatdatadog deleted the trishankatdatadog/add-verification-workflows branch January 28, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

@vdice vdice vdice approved these changes

@radu-matei radu-matei radu-matei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trishankatdatadog @technosophos @vdice @radu-matei