Skip to content

Some memo refactors #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Some memo refactors #108

merged 3 commits into from
May 14, 2025

Conversation

connortsui20
Copy link
Member

Problem

There were a few inefficiencies in the memo table (mainly extraneous clones, and how remapping of objects like goals and expressions work). Also, some of the function docs were quite verbose.

Summary of changes

This PR cleans up some of the memo table modules style and documentation, as well as removes several extraneous clones.

@connortsui20 connortsui20 requested a review from AlSchlo May 14, 2025 14:30
@connortsui20 connortsui20 changed the title Connor/clean memo Some memo refactors May 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 70.53571% with 33 lines in your changes missing coverage. Please review.

Project coverage is 82.6%. Comparing base (ed681b5) to head (f51e4f3).

Files with missing lines Patch % Lines
optd/src/memo/memory/materialize.rs 27.5% 21 Missing ⚠️
optd/src/memo/memory/helpers.rs 85.5% 12 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
optd/src/memo/memory/implementation.rs 90.8% <ø> (ø)
optd/src/memo/memory/helpers.rs 85.9% <85.5%> (-2.1%) ⬇️
optd/src/memo/memory/materialize.rs 58.4% <27.5%> (+1.1%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlSchlo AlSchlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, please ensure that nothing gets broken by running the fuzzing tests again.

@AlSchlo AlSchlo merged commit 570efc9 into main May 14, 2025
12 checks passed
@AlSchlo AlSchlo deleted the connor/clean-memo branch May 14, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants