Fix gun_user bad index runtimes: comp_lookup is a lazy list#12444
Open
Drulikar wants to merge 2 commits into
Open
Fix gun_user bad index runtimes: comp_lookup is a lazy list#12444Drulikar wants to merge 2 commits into
Drulikar wants to merge 2 commits into
Conversation
cmss13-ci
Bot
added
Fix
Member
|
This shouldn't use comp_lookup at all, it's DCS internals Isn't override = TRUE on the signal registration an option here instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR just fixes a runtime where a lazy list is accessed but lazylists are called lazy because they should be null when empty.
Explain why it's good for the game
Fixes
Testing Photographs and Procedure
Dropped and shot a gun a bunch.
Changelog
🆑 Drathek
fix: Fixed a runtime with set_gun_user causing a bad index because its a lazy list
/:cl: