Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pythia6]Move pythia6_pdfdummy in to separate tool #9514

Open
wants to merge 2 commits into
base: IB/CMSSW_14_2_X/master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_2_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 13, 2024

please test

This will fail where pythia6_pdfdummy is explicitly needed

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9514 was updated.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 13, 2024

please test

This will fail where pythia6_pdfdummy is explicitly needed

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04d0ec/42792/summary.html
COMMIT: 4c5087f
CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9514/42792/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_13_2_0_pre2-el8_amd64_gcc12/build/CMSSW_13_2_0_pre2-build/BUILD/el8_amd64_gcc12/external/pythia6/426-c430ea6f2967f65248af15c71e6c653e/pythia6/426/src/pypdfu.f:242: undefined reference to `pdfset_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_13_2_0_pre2-el8_amd64_gcc12/build/CMSSW_13_2_0_pre2-build/BUILD/el8_amd64_gcc12/external/pythia6/426-c430ea6f2967f65248af15c71e6c653e/pythia6/426/src/pypdfu.f:166: undefined reference to `structp_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-11-12-2300/external/el8_amd64_gcc12/lib/libpythia6.a(pypdel.o): in function `pypdel_':
/data/cmsbld/jenkins/workspace/auto-builds/CMSSW_13_2_0_pre2-el8_amd64_gcc12/build/CMSSW_13_2_0_pre2-build/BUILD/el8_amd64_gcc12/external/pythia6/426-c430ea6f2967f65248af15c71e6c653e/pythia6/426/src/pypdel.f:159: undefined reference to `structm_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_13_2_0_pre2-el8_amd64_gcc12/build/CMSSW_13_2_0_pre2-build/BUILD/el8_amd64_gcc12/external/pythia6/426-c430ea6f2967f65248af15c71e6c653e/pythia6/426/src/pypdel.f:91: undefined reference to `pdfset_'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/GeneratorInterface/GenExtensions/bin/GeneratorInterfaceBCVEGPY/libGeneratorInterfaceBCVEGPY.so] Error 1
Leaving library rule at src/GeneratorInterface/GenExtensions/bin
>> Leaving Package GeneratorInterface/GenExtensions
>> Package GeneratorInterface/GenExtensions built
>> Entering Package GeneratorInterface/TauolaInterface


@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46684

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04d0ec/42794/summary.html
COMMIT: 4c5087f
CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9514/42794/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04d0ec/42794/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04d0ec/42794/git-merge-result

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343588
  • DQMHistoTests: Total failures: 449
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343119
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio: This PR was tested with cms-sw/cmssw#46684, please check if they should be merged together

@smuzaffar
Copy link
Contributor Author

+externals

This should go in along with cms-sw/cmssw#46684

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#46684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants