Update tests to work around segfault on PHP 8.4.4 with Xdebug 3.5.0-dev #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the tests to work around a segfault on PHP 8.4.4 with Xdebug 3.5.0-dev.
We've started seeing consistent segfaults on PHP 8.4 only while working on #172. The tests worked just fine last Saturday (https://github.com/clue/reactphp-redis/actions/runs/13345833218) and started failing the next day (https://github.com/clue/reactphp-redis/actions/runs/13358390672) after applying some non-substantial style changes. Reverting these changes didn't change anything, so we went on to check for platform changes.
The build output above suggests the Saturday output used PHP 8.4.3, while Sunday used PHP 8.4.4. The
shivammathur/setup-php@v2
action suggests both builds use the sameXdebug 3.5.0-dev enabled as coverage driver
, while all older PHP versions useXdebug-3.4.1
. After toying around with some different approaches, it looks like always pinning this to the stable Xdebug version fixes this consistently, so I assume there might be some incompatibility between the Xdebug dev version and the most current PHP version only.Using the stable Xdebug version seems reasonable and doesn't seem to cause any noticeable side-effects. I noticed only the PHP 8.4 install now takes ~15 seconds longer because the Xdebug version doesn't appear to be cached by default.
I wonder how widespread this problem would be exactly, as I don't see anything special that this project would execute (except perhaps for Fibers as of #149?). In either case, we should probably report this upstream to Xdebug and/or shivammathur/setup-php.
Builds on top of #164
Refs #172