Compat/php8.4 support #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[2.x] Run tests on PHP 8.3 and update test suite
[2.x] Forward compatibility with Promise v3
clue
reviewed
Dec 27, 2024
There was a problem hiding this comment.
@Amir-adibi Thank you for looking into this, I definitely plan to get this in for the next release!
Unfortunately this requires a bit more work to support legacy PHP versions as suggested in #157. The good news is, I've already prepared all the required changes and have just backported this to v2 with #165.
As such, I think this should be done now! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.