Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): support append_location when append_key = '' #1285

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zhaozhihom
Copy link

What type of PR is this?

Support append_location when append_key is not 'method' or 'service'.

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Support append_location when append_key is not 'method' or 'service'
zh(optional): 当append_key不等于'method'或'service'的时候,支持从append_location插入内容

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@zhaozhihom zhaozhihom requested review from a team as code owners February 27, 2025 11:02
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhaozhihong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.21%. Comparing base (463ad91) to head (d78f2c5).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1285      +/-   ##
===========================================
- Coverage    73.17%   72.21%   -0.97%     
===========================================
  Files          138      138              
  Lines        13533    16137    +2604     
===========================================
+ Hits          9903    11653    +1750     
- Misses        3035     3887     +852     
- Partials       595      597       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marina-Sakai
Copy link
Contributor

Hi, @zhaozhihom, may I ask more about the background? Specifically, the scenario where append_key is neither 'method' nor 'service'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants