feat: add InitTrace to Langfuse #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
from
235824c to
70aa57d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 268 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 267 | 1 | 0 | 0 |
Click to see the invalid file list
- callbacks/langfuse/trace.go
|
go-test-coverage report: |
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
from
70aa57d to
cd096db
Compare
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
from
cd096db to
c0721da
Compare
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
4 times, most recently
from
00ef155 to
96d9c4f
Compare
hi-pender
reviewed
Mar 10, 2025
callbacks/langfuse/trace.go
Outdated
| "github.com/cloudwego/eino-ext/libs/acl/langfuse" | ||
| ) | ||
|
|
||
| func (c *CallbackHandler) InitTrace(ctx context.Context, opts ...TraceOption) (context.Context, error) { |
There was a problem hiding this comment.
- 这个用起来不太方便，所有需要请求粒度注入 TraceOption 的地方，都需要能拿到 CallbackHandler 实例。
- 感觉数据的传递也不是很纯粹，即使用了 context， 也是使用了 state 实例
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
from
96d9c4f to
11f9d50
Compare
N3kox
reviewed
Mar 11, 2025
callbacks/langfuse/langfuse.go
Outdated
| return &model.CallbackInput{Config: &model.Config{}} | ||
| } | ||
| if in.Config == nil { | ||
| in.Config = &model.Config{} |
There was a problem hiding this comment.
这里 set 可能有并发问题，如果必须非空的话开个新的 *model.CallbackInput 吧。
meguminnnnnnnnn
force-pushed
the
feat/wdz/langfuse_init_trace
branch
from
11f9d50 to
47943fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: