Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add the milvus 2.x indexer and retriever implementation #126

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Wenrh2004
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

新增 Milvus 2.x 版本向量存储支持

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Add the Milvus 2.x indexer and retriever implementation for Eino, which implements the Indexer and Retriever interfaces. This enables seamless integration with Eino's vector storage and retrieval system for enhanced semantic search capabilities.
zh(optional): 新增针对 Milvus 2.x 版本的支持,分别实现了 EinoIndexerRetriever 接口,无缝集成 Eino 的向量存储和检索系统,增强语义搜索能力。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Wenrh2004 Wenrh2004 requested a review from N3kox March 5, 2025 12:07
@N3kox
Copy link
Contributor

N3kox commented Mar 10, 2025

@Wenrh2004 Apologies for the delay.
I have added a few additional comments. Please ensure these are addressed.
Additionally, please verify that this PR has been thoroughly tested in a real Milvus environment.

@Wenrh2004
Copy link
Contributor Author

OK, I'll think about it.

I tested this part under zilliz.

@Wenrh2004 Wenrh2004 requested a review from N3kox March 10, 2025 17:00
@N3kox
Copy link
Contributor

N3kox commented Mar 11, 2025

@Wenrh2004 please take a look at unit test failures when you have a moment.

@Wenrh2004
Copy link
Contributor Author

@Wenrh2004 please take a look at unit test failures when you have a moment.

I fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants