Skip to content

add additional users feature#69

Closed
idjemaoune wants to merge 2 commits intocloudposse:mainfrom
idjemaoune:additional_users_feature
Closed

add additional users feature#69
idjemaoune wants to merge 2 commits intocloudposse:mainfrom
idjemaoune:additional_users_feature

Conversation

@idjemaoune
Copy link
Copy Markdown

what
Add support for setting up additional MQ users
why
Additional users were needed for the project
Full backward compatibility. Nothing will change if variables mq_additional_users or mq_configuration are undefined.

@idjemaoune idjemaoune requested review from a team as code owners October 17, 2023 09:26
@idjemaoune
Copy link
Copy Markdown
Author

@dotCipher @jamengual Please consider adding this development, as we really need this feature.

@jamengual
Copy link
Copy Markdown

@idjemaoune could you please run make precommit/terraform and commit the changes? thanks.

@hans-d
Copy link
Copy Markdown
Contributor

hans-d commented Mar 2, 2024

/terratest

@hans-d
Copy link
Copy Markdown
Contributor

hans-d commented Mar 3, 2024

@idjemaoune Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 9, 2024

Thanks @idjemaoune for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify Bot added triage Needs triage and removed stale This PR has gone stale labels Mar 16, 2024
@mergify
Copy link
Copy Markdown

mergify Bot commented May 29, 2025

💥 This pull request now has conflicts. Could you fix it @idjemaoune? 🙏

@mergify mergify Bot added the conflict This PR has conflicts label May 29, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 29, 2025

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify Bot closed this May 29, 2025
@mergify mergify Bot removed conflict This PR has conflicts triage Needs triage labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants