Input install-wrapper Deprecation
#101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tall-wrapper-parameter-deprecated # Conflicts: # dist/index.js # package-lock.json
osterman
approved these changes
Apr 25, 2025
mcalhoun
reviewed
May 1, 2025
| import * as semver from "semver"; | ||
|
|
||
| import { getAtmosBinaryName, getAtmosWrappedBinaryName } from "./atmos-bin"; | ||
| import { getAtmosBinaryName } from "./atmos-bin"; |
There was a problem hiding this comment.
I think we don't need this complicated logic anymore because we are removing the wrapper? We just need to see if it's windows and add .exe, otherwise it's atmos?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
install-wrapperinput.Why
install-wrapper, when defaulted totrue, has caused several issues:logs.filesetting specified in a repository’satmos.yaml.