feat: Atmos Terraform Plan Upload #1272
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage 49.16% 49.17%
=======================================
Files 233 233
Lines 25548 25645 +97
=======================================
+ Hits 12561 12610 +49
- Misses 11328 11370 +42
- Partials 1659 1665 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
internal/exec/pro.go
Outdated
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| // Error variables for pro package |
Check failure
Code scanning / golangci-lint
Comment should end in a period
internal/exec/pro.go
Outdated
| } | ||
|
|
||
| flags := cmd.Flags() | ||
|
|
||
| component, err := flags.GetString("component") | ||
| if err != nil { | ||
| return ProLockUnlockCmdArgs{}, err | ||
| return ProLockUnlockCmdArgs{}, fmt.Errorf("%w: %v", ErrFailedToGetComponentFlag, err) |
Check failure
Code scanning / golangci-lint
add-constant: string literal "%w: %v" appears, at least, 4 times, create a named constant for it
pkg/pro/api_client.go
Outdated
| } | ||
|
|
||
| c.Logger.Trace(fmt.Sprintf("\nUploading the affected components and stacks to %s", url)) | ||
|
|
||
| resp, err := c.HTTPClient.Do(req) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to make request: %w", err) | ||
| return fmt.Errorf("%w: %w", ErrFailedToMakeRequest, err) |
Check failure
Code scanning / golangci-lint
add-constant: string literal "%w: %w" appears, at least, 4 times, create a named constant for it
|
💥 This pull request now has conflicts. Could you fix it @milldr? 🙏 |
milldr
force-pushed
the
feat/atmos-list-upload
branch
from
cc6cb2a to
444a29a
Compare
|
merged into #1254 |
|
These changes were released in v1.188.0-test.0. |
Important
Work in progress!
what
why
references