-
Notifications
You must be signed in to change notification settings - Fork 324
Feature/implement space quotas version 3 api #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SaifuddinMerchant
wants to merge
23
commits into
cloudfoundry:main
from
SaifuddinMerchant:feature/implement-spacequotas-version-3-api
Closed
Feature/implement space quotas version 3 api #1305
SaifuddinMerchant
wants to merge
23
commits into
cloudfoundry:main
from
SaifuddinMerchant:feature/implement-spacequotas-version-3-api
+1,933
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and Delete OrganizationQuotaDefinition
…est to test appropriate builder Merge in GAPOSS/oss-fork-cloudfoundry-cf-java-client from feature/fix-test-case-for-delet-organization-request to oss-contribution-approval-organization-quotas * commit '07b697ca7627f89ce316ba199d3eb5e59489572a': minor fix for DeleteOrganizationRequestTest to test appropriate builder
…ganizationQuotaDefinition
…version 3 api Merge in GAPOSS/oss-fork-cloudfoundry-cf-java-client from feature/implement-organizationquotas-version-3-api to oss-contribution-approval-organization-quotas * commit 'c429295f5dd11c72efe77219b2f20fa7504b523c': issue-1168 adding integration test for version 3 implementation of OrganizationQuotaDefinition minor fix for DeleteOrganizationRequestTest to test appropriate builder issue-1168 adding reactor implementation for Create, Get, List, Update and Delete OrganizationQuotaDefinition issue-1168 adding interface and model for DeleteOrganizationQuotaDefinition issue-1168 adding interface and model for UpdateOrganizationQuotaDefinition issue-1168 adding interface and model for ListOrganizationQuotaDefinition issue-1168 adding interface and model for GetOrganizationQuotaDefinition issue-1168 adding interface and model for CreateOrganizationQuotaDefinition
…st, update and delete operations
…st, update and delete operations
Contributor
|
I've been trying to run integration tests on this but the PR has drifted too much behind. @SaifuddinMerchant please squash all your commits into one, and rebase onto main. |
Contributor
Author
|
ack, I will rebase on main in a day or two and push the commits |
Contributor
Author
Contributor
|
Closed in favor of #1320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an implementation of all API for the Space Quota except for Apply / Remove an space quota to an Space
I plan to implement that Apply API in a future PR. The Space Quota follows the pattern that Organization Quota version 3 API interface and implementation follow
The PR is ready for review and all changes from main have been merged and merge-conflicts resolved.