Remove old property: destroy_containers_on_start #1284
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
|
Looks good, but can you please open the PR against the "develop" branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to review the questions before submitting the PR
🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫
WHAT is this change about?
Removing the destroy_containers_on_start: true property as it will be set as true by default.
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Alana is no need to manage the destroy_containers_on_start property as it is always true.
Please provide any contextual information.
cloudfoundry/garden-runc-release#381
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Alana is no need to manage the destroy_containers_on_start property as it is always true.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
NA. Just removing the unused require_tls property.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!