Skip to content

Conversation

kart2bc
Copy link
Contributor

@kart2bc kart2bc commented Sep 17, 2025

Please take a moment to review the questions before submitting the PR

🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫

WHAT is this change about?

Removing the enableDeclarativeHealthCheck: true property as it will be set by default.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana is no need to manage the enableDeclarativeHealthCheck property as it is always true.

Please provide any contextual information.

cloudfoundry/diego-release#1022

Released on tag: https://github.com/cloudfoundry/diego-release/releases/tag/v2.119.0

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

Alana is no need to manage the enableDeclarativeHealthCheck property as it is always true.

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

NA. Just removing the unused enableDeclarativeHealthCheck property.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.
@cloudfoundry/wg-app-runtime-platform-diego-approvers

@ard-wg-gitbot
Copy link
Contributor

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

@kart2bc kart2bc changed the base branch from main to develop September 22, 2025 15:35
@ameowlia
Copy link
Member

👍 This is approved on my end.

@jochenehret jochenehret self-requested a review September 30, 2025 11:02
@jochenehret jochenehret merged commit 3d95983 into cloudfoundry:develop Sep 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants