Skip to content

Conversation

@bonzofenix
Copy link
Contributor

No description provided.

 • Introduce a new GitHub Actions workflow for post-processing dependency updates.
 • Trigger workflow on pull requests affecting specific paths and on manual dispatch.
 • Configure git with the author details of the last commit.
 • Utilize devbox-install-action for setting up the development environment.
 • Implement steps to tidy Go modules and update package specifications.
 • Ensure no redundant workflow runs by checking the last commit message.
 • Handle submodule deinitialization and cleanup for branch switching.
 • Add conditional logic to commit and push changes if necessary files are modified.
@github-advanced-security
Copy link
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

 - Modify dependency update workflow triggers to include root and all subdirectory go.mod and go.sum files
 - Add `update-uaac-nix-package` target to Makefile for updating the UAAC Nix package
@bonzofenix bonzofenix self-assigned this Nov 24, 2025
bonzofenix and others added 5 commits November 24, 2025 11:04
 - Modify CodeQL analysis workflow to only include 'go' and 'java' languages, removing 'ruby'.
 - Add a new Go program for formatting checkstyle results, capable of parsing XML and outputti
 formatted error messages.
p
removes src/autoscaler submodule references ported from
app-autoscaler-release workflow
@bonzofenix bonzofenix force-pushed the add-missing-workflows branch from eacc8ea to 7616172 Compare November 24, 2025 12:09
# Checkstyle #
#####################################################################
echo "Running Checkstyle using $DOWNLOAD_PATH"/"$CHECKSTYLE_JAR_NAME..."
trap "rm ${result_log} || echo " EXIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Use single quotes, otherwise this expands now rather than when signalled. SC2064

#####################################################################
echo "Running Checkstyle using $DOWNLOAD_PATH"/"$CHECKSTYLE_JAR_NAME..."
trap "rm ${result_log} || echo " EXIT
CHECKSTYLE_OUTPUT=$(java \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
CHECKSTYLE_OUTPUT appears unused. Verify use (or export if used externally). SC2034

-jar "$DOWNLOAD_PATH"/"$CHECKSTYLE_JAR_NAME" \
-p "${CHECKSTYLE_CONFIG_PATH}"/checkstyle.properties \
-c "${CHECKSTYLE_CONFIG_PATH}"/"${CHECKSTYLE_CONFIG_FILE_NAME}" \
-o "${result_log}" $changed_java_files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
-jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -n --skip-javadoc-formatting $changed_java_files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

echo -e "These file(s) have formatting issues: \n$files_to_be_formatted\n"
files_to_be_formatted=$(echo "$files_to_be_formatted" |tr '\n' ' ')
echo "Please correct the formatting of the files(s) using one of the following options:"
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
The surrounding quotes actually unquote this. Remove or escape them. SC2027

echo -e "These file(s) have formatting issues: \n$files_to_be_formatted\n"
files_to_be_formatted=$(echo "$files_to_be_formatted" |tr '\n' ' ')
echo "Please correct the formatting of the files(s) using one of the following options:"
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

echo -e "These file(s) have formatting issues: \n$files_to_be_formatted\n"
files_to_be_formatted=$(echo "$files_to_be_formatted" |tr '\n' ' ')
echo "Please correct the formatting of the files(s) using one of the following options:"
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
The surrounding quotes actually unquote this. Remove or escape them. SC2027

-jar "$DOWNLOAD_PATH"/"$CHECKSTYLE_JAR_NAME" \
-p "${CHECKSTYLE_CONFIG_PATH}"/checkstyle.properties \
-c "${CHECKSTYLE_CONFIG_PATH}"/"${CHECKSTYLE_CONFIG_FILE_NAME}" \
-o "${result_log}" $changed_java_files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
-o "${result_log}" $changed_java_files)
-o "${result_log}" "$changed_java_files")

--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
-jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -n --skip-javadoc-formatting $changed_java_files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
-jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -n --skip-javadoc-formatting $changed_java_files)
-jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -n --skip-javadoc-formatting "$changed_java_files")

echo -e "These file(s) have formatting issues: \n$files_to_be_formatted\n"
files_to_be_formatted=$(echo "$files_to_be_formatted" |tr '\n' ' ')
echo "Please correct the formatting of the files(s) using one of the following options:"
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar "$DOWNLOAD_PATH"/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"
echo " java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED -jar ""$DOWNLOAD_PATH""/"$GOOGLE_JAR_NAME" -replace --skip-javadoc-formatting $files_to_be_formatted"

@@ -0,0 +1,142 @@
## Code Quality
Autoscaler uses [Pre-commit](https://pre-commit.com/) for keeping our code base clean. It is a package manager fo git hooks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with hooks, it’s profane in some cases hooks retext-profanities

gofmt -s -w api/brokerserver/broker_handler.go

```
For Java, just correct the variable name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


```

To fix them, just execute the command as suggested by the java-formatter. It will auto-format the java sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
just may be insensitive, try not to use it just retext-equality


```

To fix them, just execute the command as suggested by the java-formatter. It will auto-format the java sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with execute, it’s profane in some cases execute retext-profanities


```

### Skip Pre-Commit Git Hook Locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with Hook, it’s profane in some cases hook retext-profanities

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant