update dependencies (#213)

Signed-off-by: Kangrui Johann Ye <[email protected]>
cloudflightio · Jan 5, 2024 · 2e05569 · 2e05569
1 parent 615cfd8
commit 2e05569
Show file tree

Hide file tree

Showing 49 changed files with 389 additions and 913 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin",
-    "version": "0.22.0",
+    "version": "0.23.0",
     "private": true,
     "volta": {
         "node": "20.10.0",
@@ -28,27 +28,28 @@
     "author": "Cloudflight GmbH",
     "license": "Apache-2.0",
     "devDependencies": {
-        "@angular-eslint/eslint-plugin": "16.3.1",
-        "@angular-eslint/eslint-plugin-template": "16.3.1",
-        "@angular-eslint/template-parser": "16.3.1",
-        "@rushstack/eslint-patch": "1.6.0",
-        "@types/eslint": "8.44.8",
+        "@angular-eslint/eslint-plugin": "17.1.1",
+        "@angular-eslint/eslint-plugin-template": "17.1.1",
+        "@angular-eslint/template-parser": "17.1.1",
+        "@rushstack/eslint-patch": "1.6.1",
+        "@types/eslint": "8.56.1",
         "@types/estree": "1.0.5",
         "@types/jest": "29.5.11",
-        "@types/node": "20.10.4",
-        "@typescript-eslint/eslint-plugin": "6.14.0",
-        "@typescript-eslint/parser": "6.14.0",
+        "@types/node": "20.10.6",
+        "@typescript-eslint/eslint-plugin": "6.17.0",
+        "@typescript-eslint/parser": "6.17.0",
+        "@typescript-eslint/utils": "6.17.0",
         "@vue/eslint-config-typescript": "12.0.0",
-        "eslint": "8.55.0",
-        "eslint-plugin-import": "2.29.0",
+        "eslint": "8.56.0",
+        "eslint-plugin-import": "2.29.1",
         "eslint-plugin-json-es": "1.5.7",
         "eslint-plugin-jsx-a11y": "6.8.0",
         "eslint-plugin-no-unsanitized": "4.0.2",
         "eslint-plugin-node": "11.1.0",
         "eslint-plugin-react": "7.33.2",
         "eslint-plugin-react-hooks": "4.6.0",
         "eslint-plugin-rxjs": "5.0.3",
-        "eslint-plugin-security": "1.7.1",
+        "eslint-plugin-security": "2.1.0",
         "eslint-plugin-vue": "9.19.2",
         "husky": "8.0.3",
         "jest": "29.7.0",

diff --git a/packages/eslint-plugin-angular/README.md b/packages/eslint-plugin-angular/README.md
@@ -9,7 +9,7 @@ You can find the directory of all rules including their reasoning [here](src/con
 The following dependencies are required:
 
 ```
-"@cloudflight/eslint-plugin-typescript": ">=0.22.0",
+"@cloudflight/eslint-plugin-typescript": ">=0.23.0",
 "@rushstack/eslint-patch": "1.2.0",
 "eslint": ">=8.0.0 <9.0.0"
 ```

diff --git a/packages/eslint-plugin-angular/package.json b/packages/eslint-plugin-angular/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-angular",
-    "version": "0.22.0",
+    "version": "0.23.0",
     "description": "Cloudflight eslint-plugin & eslint-config for angular",
     "volta": {
         "extends": "../../package.json"
@@ -26,9 +26,9 @@
         "build-package": "tsc"
     },
     "dependencies": {
-        "@angular-eslint/eslint-plugin": "^16.3.1",
-        "@angular-eslint/eslint-plugin-template": "^16.3.1",
-        "@angular-eslint/template-parser": "^16.3.1"
+        "@angular-eslint/eslint-plugin": "^17.1.1",
+        "@angular-eslint/eslint-plugin-template": "^17.1.1",
+        "@angular-eslint/template-parser": "^17.1.1"
     },
     "peerDependencies": {
         "@cloudflight/eslint-plugin-typescript": "workspace:*",

diff --git a/packages/eslint-plugin-angular/src/configs/index.ts b/packages/eslint-plugin-angular/src/configs/index.ts
@@ -4,7 +4,7 @@ import {FormatConfig, RecommendedConfig} from './recommended/recommended.config'
 import {FormattingHtmlConfig, RecommendedHtmlConfig} from './recommended-html/recommended-html.config';
 import {RecommendedTypescriptConfig} from './recommended-typescript/recommended-typescript.config';
 
-export const configs: Record<string, TSESLint.Linter.Config> = {
+export const configs: Record<string, TSESLint.Linter.ConfigType> = {
     'recommended-typescript': RecommendedTypescriptConfig,
     'recommended-html': RecommendedHtmlConfig,
     'html-formatting': FormattingHtmlConfig,

diff --git a/packages/eslint-plugin-angular/src/configs/recommended-html/recommended-html.config.ts b/packages/eslint-plugin-angular/src/configs/recommended-html/recommended-html.config.ts
@@ -3,7 +3,7 @@ import {TSESLint} from '@typescript-eslint/utils';
 import {angularTemplateEslintRules} from './rules/angular-eslint-template';
 import {formatAngularTemplateEslintRules} from './rules/format';
 
-export const RecommendedHtmlConfig: TSESLint.Linter.Config = {
+export const RecommendedHtmlConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/angular', '@angular-eslint/template'],
     parser: '@angular-eslint/template-parser',
     extends: ['plugin:@angular-eslint/template/accessibility', 'plugin:@angular-eslint/template/recommended'],
@@ -12,7 +12,7 @@ export const RecommendedHtmlConfig: TSESLint.Linter.Config = {
     },
 };
 
-export const FormattingHtmlConfig: TSESLint.Linter.Config = {
+export const FormattingHtmlConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/angular', '@angular-eslint/template'],
     parser: '@angular-eslint/template-parser',
     extends: [],

diff --git a/...eslint-plugin-angular/src/configs/recommended-typescript/recommended-typescript.config.ts b/...eslint-plugin-angular/src/configs/recommended-typescript/recommended-typescript.config.ts
@@ -4,7 +4,7 @@ import {angularEslintRules} from './rules/angular-eslint';
 import {eslintRules} from './rules/eslint';
 import {typescriptEslintRules} from './rules/typescript-eslint';
 
-export const RecommendedTypescriptConfig: TSESLint.Linter.Config = {
+export const RecommendedTypescriptConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/angular', '@cloudflight/typescript', '@angular-eslint'],
     parser: '@typescript-eslint/parser',
     extends: ['plugin:@cloudflight/typescript/recommended'],

diff --git a/packages/eslint-plugin-angular/src/configs/recommended/recommended.config.ts b/packages/eslint-plugin-angular/src/configs/recommended/recommended.config.ts
@@ -1,6 +1,6 @@
 import {TSESLint} from '@typescript-eslint/utils';
 
-export const RecommendedConfig: TSESLint.Linter.Config = {
+export const RecommendedConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/angular'],
     overrides: [
         {
@@ -14,7 +14,7 @@ export const RecommendedConfig: TSESLint.Linter.Config = {
     ],
 };
 
-export const FormatConfig: TSESLint.Linter.Config = {
+export const FormatConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/angular'],
     overrides: [
         {

diff --git a/packages/eslint-plugin-angular/tsconfig.json b/packages/eslint-plugin-angular/tsconfig.json
@@ -4,7 +4,8 @@
         "target": "ES2015",
         "useDefineForClassFields": true,
 
-        "module": "CommonJS",
+        "module": "NodeNext",
+        "moduleResolution": "NodeNext",
 
         "declaration": true,
         "outDir": "./dist/",

diff --git a/packages/eslint-plugin-node/README.md b/packages/eslint-plugin-node/README.md
@@ -9,7 +9,7 @@ You can find the directory of all rules including their reasoning [here](src/con
 The following dependencies are required:
 
 ```
-"@cloudflight/eslint-plugin-typescript": ">=0.22.0",
+"@cloudflight/eslint-plugin-typescript": ">=0.23.0",
 "@rushstack/eslint-patch": "1.2.0",
 "eslint": ">=8.0.0 <9.0.0"
 ```

diff --git a/packages/eslint-plugin-node/package.json b/packages/eslint-plugin-node/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-node",
-    "version": "0.22.0",
+    "version": "0.23.0",
     "description": "Cloudflight eslint-plugin & eslint-config for node",
     "volta": {
         "extends": "../../package.json"
@@ -28,7 +28,7 @@
     "dependencies": {
         "eslint-plugin-no-unsanitized": "^4.0.2",
         "eslint-plugin-node": "^11.1.0",
-        "eslint-plugin-security": "^1.7.1"
+        "eslint-plugin-security": "^2.1.0"
     },
     "peerDependencies": {
         "@cloudflight/eslint-plugin-typescript": "workspace:*",

diff --git a/packages/eslint-plugin-node/src/configs/index.ts b/packages/eslint-plugin-node/src/configs/index.ts
@@ -1,7 +1,7 @@
-import {TSESLint} from '@typescript-eslint/utils';
+import {type TSESLint} from '@typescript-eslint/utils';
 
 import {RecommendedConfig} from './recommended/recommended.config';
 
-export const configs: Record<string, TSESLint.Linter.Config> = {
+export const configs: Record<string, TSESLint.Linter.ConfigType> = {
     recommended: RecommendedConfig,
 };
diff --git a/packages/eslint-plugin-node/src/configs/recommended/recommended.config.ts b/packages/eslint-plugin-node/src/configs/recommended/recommended.config.ts
@@ -1,11 +1,11 @@
 import {TSESLint} from '@typescript-eslint/utils';
 
-export const RecommendedConfig: TSESLint.Linter.Config = {
+export const RecommendedConfig: TSESLint.Linter.ConfigType = {
     extends: [
         'plugin:@cloudflight/typescript/recommended',
         'plugin:node/recommended',
         'plugin:no-unsanitized/DOM',
-        'plugin:security/recommended',
+        'plugin:security/recommended-legacy',
     ],
     rules: {
         // require all requires be top-level

diff --git a/packages/eslint-plugin-node/tsconfig.json b/packages/eslint-plugin-node/tsconfig.json
@@ -4,7 +4,8 @@
         "target": "ES2015",
         "useDefineForClassFields": true,
 
-        "module": "CommonJS",
+        "module": "NodeNext",
+        "moduleResolution": "NodeNext",
 
         "declaration": true,
         "outDir": "./dist/",

diff --git a/packages/eslint-plugin-react/README.md b/packages/eslint-plugin-react/README.md
@@ -9,7 +9,7 @@ You can find the directory of all rules including their reasoning [here](src/con
 The following dependencies are required:
 
 ```
-"@cloudflight/eslint-plugin-typescript": ">=0.22.0",
+"@cloudflight/eslint-plugin-typescript": ">=0.23.0",
 "@rushstack/eslint-patch": "1.2.0",
 "eslint": ">=8.0.0 <9.0.0"
 ```

diff --git a/packages/eslint-plugin-react/package.json b/packages/eslint-plugin-react/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-react",
-    "version": "0.22.0",
+    "version": "0.23.0",
     "description": "Cloudflight eslint-plugin & eslint-config for React",
     "volta": {
         "extends": "../../package.json"

diff --git a/packages/eslint-plugin-react/src/configs/index.ts b/packages/eslint-plugin-react/src/configs/index.ts
@@ -2,6 +2,6 @@ import {TSESLint} from '@typescript-eslint/utils';
 
 import {RecommendedConfig} from './recommended/recommended.config';
 
-export const configs: Record<string, TSESLint.Linter.Config> = {
+export const configs: Record<string, TSESLint.Linter.ConfigType> = {
     recommended: RecommendedConfig,
 };
diff --git a/packages/eslint-plugin-react/src/configs/recommended/recommended.config.ts b/packages/eslint-plugin-react/src/configs/recommended/recommended.config.ts
@@ -1,6 +1,6 @@
 import {TSESLint} from '@typescript-eslint/utils';
 
-export const RecommendedConfig: TSESLint.Linter.Config = {
+export const RecommendedConfig: TSESLint.Linter.ConfigType = {
     extends: [
         'plugin:@cloudflight/typescript/recommended',
         'plugin:react/recommended',

diff --git a/packages/eslint-plugin-react/tsconfig.json b/packages/eslint-plugin-react/tsconfig.json
@@ -4,7 +4,8 @@
         "target": "ES2015",
         "useDefineForClassFields": true,
 
-        "module": "CommonJS",
+        "module": "NodeNext",
+        "moduleResolution": "NodeNext",
 
         "declaration": true,
         "outDir": "./dist/",

diff --git a/packages/eslint-plugin-typescript/package.json b/packages/eslint-plugin-typescript/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-typescript",
-    "version": "0.22.0",
+    "version": "0.23.0",
     "description": "Cloudflight eslint-plugin & eslint-config for typescript",
     "volta": {
         "extends": "../../package.json"
@@ -27,9 +27,9 @@
         "test-package": "jest"
     },
     "dependencies": {
-        "@typescript-eslint/eslint-plugin": "^6.14.0",
-        "@typescript-eslint/parser": "^6.14.0",
-        "eslint-plugin-import": "^2.29.0",
+        "@typescript-eslint/eslint-plugin": "^6.17.0",
+        "@typescript-eslint/parser": "^6.17.0",
+        "eslint-plugin-import": "^2.29.1",
         "eslint-plugin-json-es": "^1.5.7",
         "eslint-plugin-rxjs": "^5.0.3",
         "eslint-plugin-simple-import-sort": "^10.0.0"

diff --git a/packages/eslint-plugin-typescript/src/configs/index.ts b/packages/eslint-plugin-typescript/src/configs/index.ts
@@ -5,7 +5,7 @@ import {RecommendedJsonConfig} from './recommended-json/recommended-json.config'
 import {RecommendedPackageConfig} from './recommended-package/recommended-package.config';
 import {FormattingTypescriptConfig, RecommendedTypescriptConfig} from './recommended-typescript/recommended-typescript.config';
 
-export const configs: Record<string, TSESLint.Linter.Config> = {
+export const configs: Record<string, TSESLint.Linter.ConfigType> = {
     formatting: FormattingTypescriptConfig,
     'recommended-typescript': RecommendedTypescriptConfig,
     'recommended-json': RecommendedJsonConfig,

diff --git a/packages/eslint-plugin-typescript/src/configs/recommended-json/recommended-json.config.ts b/packages/eslint-plugin-typescript/src/configs/recommended-json/recommended-json.config.ts
@@ -2,7 +2,7 @@ import {TSESLint} from '@typescript-eslint/utils';
 
 import {customRules} from './rules/custom';
 
-export const RecommendedJsonConfig: TSESLint.Linter.Config = {
+export const RecommendedJsonConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/typescript'],
     parser: 'eslint-plugin-json-es',
     rules: {

diff --git a/...es/eslint-plugin-typescript/src/configs/recommended-package/recommended-package.config.ts b/...es/eslint-plugin-typescript/src/configs/recommended-package/recommended-package.config.ts
@@ -2,7 +2,7 @@ import {TSESLint} from '@typescript-eslint/utils';
 
 import {customRules} from './rules/custom';
 
-export const RecommendedPackageConfig: TSESLint.Linter.Config = {
+export const RecommendedPackageConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/typescript'],
     parser: 'eslint-plugin-json-es',
     rules: {

diff --git a/...int-plugin-typescript/src/configs/recommended-typescript/recommended-typescript.config.ts b/...int-plugin-typescript/src/configs/recommended-typescript/recommended-typescript.config.ts
@@ -12,7 +12,7 @@ import {typescriptEslintRules} from './rules/typescript-eslint';
  * complain about unknown rules when disabling some of them
  */
 
-export const RecommendedTypescriptConfig: TSESLint.Linter.Config = {
+export const RecommendedTypescriptConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/typescript', '@typescript-eslint', 'rxjs', 'import', 'simple-import-sort'],
     parser: '@typescript-eslint/parser',
     extends: [
@@ -29,7 +29,7 @@ export const RecommendedTypescriptConfig: TSESLint.Linter.Config = {
     },
 };
 
-export const FormattingTypescriptConfig: TSESLint.Linter.Config = {
+export const FormattingTypescriptConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/typescript', '@typescript-eslint', 'rxjs', 'import', 'simple-import-sort'],
     parser: '@typescript-eslint/parser',
     extends: [],

diff --git a/packages/eslint-plugin-typescript/src/configs/recommended/recommended.config.ts b/packages/eslint-plugin-typescript/src/configs/recommended/recommended.config.ts
@@ -1,6 +1,6 @@
 import {TSESLint} from '@typescript-eslint/utils';
 
-export const RecommendedConfig: TSESLint.Linter.Config = {
+export const RecommendedConfig: TSESLint.Linter.ConfigType = {
     plugins: ['@cloudflight/typescript'],
     overrides: [
         {

diff --git a/packages/eslint-plugin-typescript/src/rules/no-moment-js.ts b/packages/eslint-plugin-typescript/src/rules/no-moment-js.ts
@@ -1,14 +1,18 @@
 import {createRule} from '../util/create-rule';
 
 export const NoMomentJsRuleName = 'no-moment-js';
+/**
+ * Comment needed to prevent type declaration generation, which is broken.
+ * @internal
+ */
 export const NoMomentJsRule = createRule<[], 'noMomentJs'>({
     name: NoMomentJsRuleName,
     meta: {
         type: 'problem',
         fixable: 'code',
         docs: {
             description: 'Enforces that all packages have absolute versions.',
-            recommended: 'error',
+            recommended: 'strict',
         },
         schema: [],
         messages: {

diff --git a/packages/eslint-plugin-typescript/src/rules/no-on-event-assign.ts b/packages/eslint-plugin-typescript/src/rules/no-on-event-assign.ts
@@ -95,14 +95,18 @@ const disallowedEvents = [
 ];
 
 export const NoOnEventAssignName = 'no-on-event-assign';
+/**
+ * Comment needed to prevent type declaration generation, which is broken.
+ * @internal
+ */
 export const NoOnEventAssign = createRule<[], 'noAssign'>({
     name: NoOnEventAssignName,
     meta: {
         type: 'problem',
         fixable: 'code',
         docs: {
             description: 'Enforces that all packages have absolute versions.',
-            recommended: 'error',
+            recommended: 'strict',
         },
         schema: [],
         messages: {

diff --git a/...t-plugin-typescript/src/rules/package/package-force-absolute-version-dependencies.rule.ts b/...t-plugin-typescript/src/rules/package/package-force-absolute-version-dependencies.rule.ts
@@ -4,14 +4,18 @@ import {findPropertyPath, getPropertyName, reportWrongPropertyValue} from '../..
 const semVerRegex = /\d+\.(\d+|x)\.(\d+|x)/;
 
 export const PackageForceAbsoluteVersionDependenciesRuleName = 'package-force-absolute-version-dependencies';
+/**
+ * Comment needed to prevent type declaration generation, which is broken.
+ * @internal
+ */
 export const PackageForceAbsoluteVersionDependenciesRule = createPackageRule<[], string>({
     name: PackageForceAbsoluteVersionDependenciesRuleName,
     meta: {
         type: 'problem',
         fixable: 'code',
         docs: {
             description: 'Enforces that all packages have absolute versions.',
-            recommended: 'error',
+            recommended: 'strict',
         },
         schema: [],
         messages: {},

diff --git a/packages/eslint-plugin-typescript/src/rules/package/package-force-private.rule.ts b/packages/eslint-plugin-typescript/src/rules/package/package-force-private.rule.ts
@@ -13,14 +13,18 @@ const privatePropertyAssertion: JsonPropertyAssertion = {
 };
 
 export const PackageForcePrivateRuleName = 'package-force-private';
+/**
+ * Comment needed to prevent type declaration generation, which is broken.
+ * @internal
+ */
 export const PackageForcePrivateRule = createPackageRule<RuleOptions[], string>({
     name: PackageForcePrivateRuleName,
     meta: {
         type: 'problem',
         fixable: 'code',
         docs: {
             description: 'Enforces that all packages are private, in other words non-publishable.',
-            recommended: 'error',
+            recommended: 'strict',
         },
         schema: [
             {