Skip to content

[o11y] Expand and refactor STW support #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

fhanau
Copy link
Contributor

@fhanau fhanau commented Mar 26, 2025

  • Add rudimentary user tracing support
  • Add support for fetch response info, ancillary fields like script tags
  • Extend lifetime of outcome event for fetch handler so that exception outcome can be reported correctly.

Upstream PR to follow.

@fhanau fhanau requested a review from jasnell March 26, 2025 19:12
@fhanau fhanau requested review from a team as code owners March 26, 2025 19:12
@fhanau fhanau requested a review from jp4a50 March 26, 2025 19:12
@fhanau fhanau force-pushed the felix/031325-tail-worker-refactor-p2-work branch 3 times, most recently from 40c57da to 80fd1cb Compare April 1, 2025 02:18
Copy link
Collaborator

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm but I agree with @danlapid's comment about the vector vs. array.

@fhanau fhanau force-pushed the felix/031325-tail-worker-refactor-p2-work branch from a1223e0 to 01c9079 Compare April 1, 2025 20:56
fhanau added 3 commits April 2, 2025 19:21
- Add rudimentary user tracing support
- Add support for fetch response info, ancillary fields like script tags
- Extend lifetime of outcome event for fetch handler so that exception outcome
  can be reported correctly.
This avoids having to recompile lots of code following tracer header changes.
@fhanau fhanau force-pushed the felix/031325-tail-worker-refactor-p2-work branch from 01c9079 to 73cf308 Compare April 2, 2025 19:28
@fhanau fhanau merged commit c0ca172 into main Apr 2, 2025
26 of 29 checks passed
@fhanau fhanau deleted the felix/031325-tail-worker-refactor-p2-work branch April 2, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants