Skip to content

test(build): characterize configured command lifecycle - #3375

Draft
james-elicx wants to merge 4 commits into
mainfrom
codex/vite-command-contract
Draft

james-elicx wants to merge 4 commits into
mainfrom
codex/vite-command-contract

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 22, 2026

Copy link
Copy Markdown
Member

Summary

  • characterize the existing configured vinext build behavior before moving lifecycle ownership
  • cover user plugins, custom output roots, production environment semantics, and hybrid Pages output
  • establish a production-semantics regression fixture that later stack layers reuse for direct Vite coverage

Validation

  • vp test run tests/vite-command-contract.test.ts
  • vp check

This is the bottom of the seven-PR Vite command lifecycle stack and changes no production behavior.

@james-elicx
james-elicx added this pull request to stack #3382 September 22, 2026 11:37
@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3375

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3375

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3375

vinext

npm i https://pkg.pr.new/vinext@3375

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3375

commit: 45976d7

@james-elicx james-elicx changed the title codex/vite command contract test(build): characterize configured command lifecycle Sep 22, 2026
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-export preview production
web preview production

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 45976d7 against base 75a0717 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ -0.0%
Client entry size (gzip) vinext 129.7 KB 129.7 KB ⚫ -0.0%
Dev server cold start vinext 3.44 s 3.39 s ⚫ -1.4%
Production build time vinext 3.96 s 3.92 s ⚫ -1.1%
RSC entry closure size (gzip) vinext 127.9 KB 127.9 KB ⚫ +0.0%
Server bundle size (gzip) vinext 226.0 KB 226.0 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

Comment thread tests/vite-command-contract.test.ts
Comment thread tests/vite-command-contract.test.ts
Comment thread tests/vite-command-contract.test.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 3 actionable inline findings. Targeted test passes.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

Comment thread tests/vite-command-contract.test.ts
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Targeted test passes.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

Comment thread tests/vite-command-contract.test.ts
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Targeted test passes.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

Comment thread tests/vite-command-contract.test.ts
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Targeted test passes.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

Comment thread tests/vite-command-contract.test.ts Outdated
@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding. Targeted test passes.

github run

@james-elicx
james-elicx force-pushed the codex/vite-command-contract branch from b375915 to 45976d7 Compare September 22, 2026 13:37
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@james-elicx Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant