fix(pages-router): preserve dynamic href history state - #3368
james-elicx wants to merge 1 commit into
Conversation
|
Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
/bigbonk review for issues |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
|
Posted 1 actionable inline finding. |
|
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
97bb7dd to
d981a07
Compare
|
Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
/bigbonk review for issues |
d981a07 to
7e9de6a
Compare
|
Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
/bigbonk review for issues |
|
Posted 1 actionable inline finding. |
7e9de6a to
818cda7
Compare
|
Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
/bigbonk review for issues |
818cda7 to
e633400
Compare
|
Posted 1 actionable inline finding. |
e633400 to
5bd2ed8
Compare
|
Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
LGTM! |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
Posted 1 actionable inline finding. |
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
|
LGTM! |
2 participants
Depends on #3367. This is the last of three cohesive Pages Router PRs for #3351; review #3354, then #3367, then this PR.
Review map
shims/router.tsandinternal/pages-data-target.ts: keep route-pattern identity, visible URL, data-fetch target, middleware probe, and history state distinct through push, replace, and popstate. Preserve same-origin absolute href, basePath, locale, relative paths, and dynamic/static collisions. Initial dynamic GSSP history retains browser search keys, with route params taking precedence.entries/pages-client-entry.ts,server/dev-server.ts,server/pages-dev-hydration.ts,index.ts: match dev page loaders, data-kind/middleware manifests, and HMR behavior to production navigation. Lazy page URLs are imported at runtime so unrelated pages are not HMR dependencies of every hydration proxy; the initial page retains its bare module identity. Qualify runtime imports with Vite’sBASE_URLfor basePath projects, without appending a duplicate?import. Vite inline HTML proxies are invalidated after classification changes.Next.js references
Validation
Locally on
9344c72e049d93af0eb38f318313ee781e93125c: 1,432 focused unit tests, HMR graph and custom-error integration tests, seven hydration browser tests (including MDX), and all three basePath-dev browser tests passed on fresh isolated servers.vp checkandvp run vinext#buildpassed. Fresh independent parity and maintainability reviews found no actionable in-scope issues. Exact-head CI and Big Bonk are still running; this PR remains draft until clean.