Add template for react-router v7 #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebp
force-pushed
the
zeb/react-router-template
branch
from
a5c190d to
1ffc9af
Compare
Introduces a template for react-router v7 that uses the @cloudflare/vite-plugin to use workerd for the local dev server.
zebp
force-pushed
the
zeb/react-router-template
branch
from
1ffc9af to
2f22f35
Compare
zebp
commented
Jan 26, 2025
| import { defineConfig } from "vite"; | ||
| import { cloudflare } from "@cloudflare/vite-plugin"; | ||
|
|
||
| // By default react-router's dev server uses Node.js, so we want to remove their server |
There was a problem hiding this comment.
I'm not sure what our position on the new vite plugin is, it does mean that we end up diverging from the "stock" framework templates more than is absolutely necessary but it does mean we get to use workerd for the dev server if we make tiny adjustments to the template. Happy to remove this if this isn't the path we want to go down.
There was a problem hiding this comment.
do what is best for the person getting started
|
YES |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a template for react-router v7 that uses the @cloudflare/vite-plugin to use workerd for the local dev server.