Allow using an externally provided secret for the tunnel credentials #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froblesmartin
force-pushed
the
allow-external-secret
branch
from
44fa2f6 to
dd42a6d
Compare
froblesmartin
force-pushed
the
allow-external-secret
branch
from
dd42a6d to
b37071c
Compare
|
I am also removing |
|
Would be great to add this, we are blocked using this chart until this PR is merged. |
|
Pinging @mattalberts and @jalateras |
|
Great addition, thanks |
|
Thanks for this contribution! |
obezuk
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised also in #36, it would be nice to be able to use an externally provided secret instead of only passing the secrets as plain text in the
values.yaml.There are many ways to provision secrets into Kubernetes securely (Sealed Secrets, CSI Provisioners, ...), and to be able to use those in a flexible way, secrets should always offer the possibility to reference them and not generate them with the Helm chart itself.
@obezuk , pinging you as I have seen you are the only maintainer interacting in this repository lately.