Batch action application with per-action veto

packages/gatekeeper-kit/__tests__/actions.test.ts

@@ -828,9 +828,13 @@ describe("defineActions", () => {
     }
   });
 
-  it("puts no pushedCommits key on the wire when the description declares none", async () => {
-    // Absent, not `undefined`: the overseer reads presence as "this action pushes".
-    const { actions } = bind();
+  it.each([
+    { declared: "no key", present: undefined },
+    { declared: "an empty list", present: () => ({ ...presentation, pushedCommits: [] }) },
+  ])("puts no pushedCommits key on the wire when the description declares $declared",
+      async ({ present }) => {
+    // Absent, not `undefined` or `[]`: the overseer reads presence as "this action pushes".
+    const { actions } = bind({ describe: present });
     const submitAction = submitSpy();
 
     await actions.submit(fakeQueue(submitAction), "execute", { sql: "one" });

packages/gatekeeper-kit/src/actions.ts

@@ -717,8 +717,9 @@ export function defineActions<Host, M extends Record<string, unknown>>(
             description,
             implementsRevert,
             // Spread, so an action with no git, no kind, or no awaited decision puts no key on the
-            // wire at all.
-            ...(pushedCommits ? { pushedCommits } : {}),
+            // wire at all. An empty list is "no git" too: the overseer reads presence as a push,
+            // and `[]` is a push of nothing it refuses to build a pack for.
+            ...(pushedCommits?.length ? { pushedCommits } : {}),
             autoApprovable: definition.autoApprovable === true,
             ...(definition.kind ? { actionKind: definition.kind } : {}),
             ...(definition.delivery === "await-decision" ? { awaitDecision: true } : {}),

packages/workshop-backend/__tests__/action-log-pagination.test.ts

@@ -1,30 +1,16 @@
 import { describe, expect, it, vi } from "vitest";
-import type { RpcStub } from "capnweb";
-import type { ActionLogEntry, ActionsSubscriber } from "@gadgets/workshop-shared/api";
+import type { ActionLogEntry } from "@gadgets/workshop-shared/api";
 import {
   ACTION_HISTORY_PAGE_DEFAULT_LIMIT, ACTION_REPLAY_PAGE_SIZE,
 } from "../src/overseer.js";
 import { makeMockStorage } from "./mock-storage.js";
 import {
-  FIXTURE_EPOCH, makeActionStorage, makePreIndexActionStorage, openFakeOverseer, putAction,
+  FIXTURE_EPOCH, makeActionStorage, makePreIndexActionStorage, makeSubscriber, openFakeOverseer,
+  putAction,
 } from "./fixtures.js";
 
 vi.mock("capnweb-validate", () => ({ validateRpc: () => () => undefined }));
 
-// Hand-rolled ActionsSubscriber stub. `events` interleaves entry ids with "ready", so tests can
-// assert both content and ordering of the delivered stream.
-function makeSubscriber(entry?: (record: ActionLogEntry) => Promise<void>) {
-  let events: Array<number | "ready"> = [];
-  let subscriber = {
-    entry: entry ?? (async (record: ActionLogEntry) => { events.push(record.id); }),
-    ready: async () => { events.push("ready"); },
-    dup: () => subscriber,
-    onRpcBroken: () => {},
-    [Symbol.dispose]: () => {},
-  };
-  return { subscriber: subscriber as unknown as RpcStub<ActionsSubscriber>, events };
-}
-
 describe("subscribeToActions", () => {
   it("delivers no pre-existing records: ready fires immediately", async () => {
     // Live deltas only — the current pending set is queried via listActions({filter: "pending"}).