Skip to content

Add support for connections to Trino with TLS enabled #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for connections to Trino with TLS enabled #4248

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8baec26
Fixed TLS support for Trino connector by adding the TLS verify option
Jimvin Sep 3, 2025
ddbeb9a
Allow passing the parameter 'verify' to Trino connection to manage TL…
Jimvin Sep 8, 2025
f18f7b2
Merge branch 'master' of https://github.com/Jimvin/hue
Jimvin Sep 8, 2025
08321c0
Fixed typo in comment
Jimvin Sep 8, 2025
98d2e64
Merge branch 'master' into master
Jimvin Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion desktop/libs/notebook/src/notebook/connectors/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,24 @@ def __init__(self, user, interpreter=None):
self.auth_password = auth_password
self.auth = BasicAuthentication(self.auth_username, self.auth_password)

if self.http_scheme == "https":
verify = self.options.get('verify')
if verify is not None:
self.verify = verify
else:
# Setting a non-existant trust store if the verify parameter is not set.
# This means that admins must explictly set verify=False to disable TLS host verification.
self.verify = '/days/of/no/trust'

self.session_info = self.create_session()
self.trino_session = ClientSession(self.user.username, properties=self.session_info['properties'])
self.trino_request = TrinoRequest(
host=self.server_host,
port=self.server_port,
client_session=self.trino_session,
http_scheme=self.http_scheme,
auth=self.auth
auth=self.auth,
verify=self.verify
)

def get_auth_password(self):
Expand Down