Instantiate chat history manager at runtime instead of import-time #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliu-cloudera
commented
Aug 26, 2025
Comment on lines
-63
to
67
| self.bucket_prefix = settings.document_bucket_prefix | ||
| self._s3_client: S3Client | None = None | ||
|
|
||
| @property | ||
| @functools.cached_property | ||
| def s3_client(self) -> S3Client: | ||
| """Lazy initialization of S3 client.""" |
There was a problem hiding this comment.
Turns out functools.cached_property is precisely the thing for "lazily initialize an instance attribute"!
This also helps avoid conflating self.s3_client and self._s3_client since conventionally, both could be used inside a class's methods.
Comment on lines
60
to
62
| def __init__(self, bucket_name: str = settings.document_bucket): | ||
| self.bucket_name = bucket_name | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.bucket_name = settings.document_bucket |
There was a problem hiding this comment.
Moving bucket_name out of the initializer params since we never use it.
mliu-cloudera
requested review from
baasitsharief,
ewilliams-cloudera and
jkwatson
baasitsharief
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of moving operations from app startup to app runtime (though this will have a negligible impact on startup time).
Also helps lay groundwork for #307.