Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53-migrate-zone: Support multiple record types per record name at destination #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joegross
Copy link

@joegross joegross commented Jun 4, 2016

Current code indexed destination record on record.name, alone, but multiple types may exist
for the same record. For example: MX, TXT, A frequently exist at the zone apex.

  • Add support for AAAA, PTR, SRV records
  • Change destination_zone_existing_resource_record_dict to use a two-level
    dictionary of [record.name][record.type]
  • Update diff_record to use passed variables instead of globals
  • Change logging for duplicate, but different, record to WARNING and
    print source and dest records

This code can likely be simplifed by changing the record type whitelist
to a blacklist of just SOA and NS records.

Current code indexed on record.name, alone, but multiple types may exist
for the same record. For example: MX, TXT, A frequently exist at the
zone apex.

- Add support for AAAA, PTR, SRV records
- Change destination_zone_existing_resource_record_dict to use a two-level
  dictionary of [record.name][record.type]
- Update diff_record to use passed variables instead of globals
- Change logging for duplicate, but different, record to WARNING and
  print source and dest records

This code can likely be simplifed by changing the record type whitelist
to a blacklist of just SOA and NS records.
@joegross joegross changed the title Support multiple record types per record name. route53-migrate-zone: Support multiple record types per record name. Jun 4, 2016
@joegross joegross changed the title route53-migrate-zone: Support multiple record types per record name. route53-migrate-zone: Support multiple record types per record name at destination Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant