Skip to content

Conversation

@JannoCAT
Copy link
Collaborator

@JannoCAT JannoCAT commented Dec 5, 2025

Description

This change adds the optional iam role path variable which allows users to specify the path of the iam role created by the repo.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Configuration change
  • ♻️ Code refactoring
  • ⚡ Performance improvement
  • ✅ Test addition or update
  • 🔒 Security improvement

Changes Made

This change is required to set the role path that is created by the repo.

Testing

  • Pre-commit hooks passed (pre-commit run -a)
  • Terraform format checked (terraform fmt -recursive)
  • Terraform validation passed (terraform validate)
  • Examples tested
  • Security scans passed (tfsec, checkov, trivy)

Documentation

  • Updated README.md (or documentation auto-generated via terraform-docs)
  • [] Updated relevant example configurations
  • Added/updated comments in code where necessary
  • [] Updated CHANGELOG.md (or will be auto-generated)

Security

  • No secrets or credentials are committed
  • Security scanning tools passed (checkov, tfsec, trivy)
  • IAM policies follow principle of least privilege
  • Security implications have been considered and documented

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have updated the documentation accordingly
  • My commit messages follow the Conventional Commits specification

Additional Notes

NA


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

@JannoCAT JannoCAT self-assigned this Dec 5, 2025
@JannoCAT JannoCAT requested a review from baolsen as a code owner December 5, 2025 09:57
@JannoCAT JannoCAT added the enhancement New feature or request label Dec 5, 2025
@JannoCAT JannoCAT changed the title chore: 2025-12-05 Add iam role path variable chore: Add iam role path variable Dec 5, 2025
@baolsen baolsen requested a review from Copilot December 5, 2025 10:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for specifying a custom IAM role path when the module creates an IAM role, providing more flexibility for users who need to organize their IAM roles using path hierarchies in their AWS account.

Key Changes

  • Added iam_role_path variable with a default value of "/" to maintain backward compatibility
  • Updated the IAM role resource to use the new iam_role_path variable
  • Auto-generated documentation updates to reflect the new variable

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
variables.tf Adds the iam_role_path variable definition with appropriate default value and description
iam.tf Updates the aws_iam_role resource to use the new path variable
README.md Auto-generated documentation update reflecting the new input variable

@JannoCAT JannoCAT force-pushed the chore/2025-12-05-Add-iam-role-path-variable branch from a0d9a3b to 8a8543c Compare December 5, 2025 10:14
@JannoCAT JannoCAT merged commit 4288d34 into main Dec 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants