fix(deps): rename Content to ContentBlock for rmcp v2; gate lint on Renovate PRs - #1343
Conversation
aba1511 to
a8eee08
Compare
There was a problem hiding this comment.
Aptu Review
✅ Approve — This PR updates the codebase to accommodate the breaking change in rmcp v2.2.0 where Content was renamed to ContentBlock. It also removes the conditional gate in the CI pipeline that previously skipped linting for Renovate-generated PRs.
Posted by aptu
a8eee08 to
79817ad
Compare
There was a problem hiding this comment.
Aptu Review
✅ Approve — This PR updates the codebase to support the breaking changes in rmcp v2.2.0, specifically renaming 'Content' to 'ContentBlock' and updating related types. It also cleans up the logging infrastructure by removing redundant MCP-specific logging level mappings and enables CI linting for Renovate-generated PRs.
- The removal of the set_level handler and log_level_filter state significantly changes the server's runtime configuration capabilities; ensure this aligns with the intended evolution of the MCP server interface.
Posted by aptu
79817ad to
184dc8c
Compare
There was a problem hiding this comment.
Aptu Review
✅ Approve — This PR updates the codebase to support rmcp v2.2.0 by renaming Content to ContentBlock and removing deprecated logging infrastructure in favor of standard tracing::Level. It also cleans up the CI configuration by removing the Renovate-specific lint gate.
- The removal of the
set_levelhandler is a breaking change for clients relying on dynamic log level adjustment via MCP, though this aligns with the cited SEP-2577.
Posted by aptu
…enovate PRs Signed-off-by: Hugues Clouatre <hugues@linux.com>
184dc8c to
c8a9fb2
Compare
There was a problem hiding this comment.
Aptu Review
✅ Approve — This PR updates the codebase to support rmcp v2.2.0 by migrating from Content to ContentBlock and removing deprecated MCP logging features. It also cleans up the CI configuration by removing the Renovate-specific skip condition for linting.
- The removal of
logging/setLevelremoves a runtime configuration capability that some users might have relied upon, though this is justified by the upstream spec change.
Posted by aptu
Summary
rmcp v2.2.0 introduced two breaking changes addressed in this PR:
Renamed
ContenttoContentBlockacross the MCP model. All import and call sites updated in 10 files. No behavior change.Deprecated
LoggingLevel,SetLevelRequestParams, and allLoggingLevelvariants (-D warningspromotes these to hard errors in CI). Rather than suppress with#[allow(deprecated)], the deprecated surface is removed entirely, aligned with MCP SEP-2577 which formally deprecated the Logging protocol feature (merged 2026-05-15) citing overlap with stderr and OpenTelemetry.What was removed:
set_levelServerHandler override (logging/setLevelrequest handler)notify_logging_messagecall sites (notifications/messageMCP log forwarding)log_level_filterfield and mutex onCodeAnalyzerLoggingLevel,SetLevelRequestParams,LevelFilterimportsWhat replaces it:
LogEvent.levelis nowtracing::LeveldirectlyRUST_LOGenv var or--log-levelCLI flagChanges
.github/workflows/ci.yml-- remove Renovate bot skip from Lint jobif-conditioncrates/aptu-coder/src/lib.rs-- remove deprecated imports andset_leveloverride; removelog_level_filterfieldcrates/aptu-coder/src/logging.rs--LogEvent.level:LoggingLevel->tracing::Level; deletelevel_to_mcpcrates/aptu-coder/src/tools/server.rs-- removelog_level_filterparametercrates/aptu-coder/src/main.rs-- updateCodeAnalyzer::new()callcrates/aptu-coder/src/tools/analyze_directory.rscrates/aptu-coder/src/tools/analyze_file.rscrates/aptu-coder/src/tools/analyze_module.rscrates/aptu-coder/src/tools/analyze_symbol.rscrates/aptu-coder/src/tools/common.rscrates/aptu-coder/src/tools/edit_overwrite.rscrates/aptu-coder/src/tools/edit_replace.rscrates/aptu-coder/src/tools/exec_command.rscrates/aptu-coder/tests/integration_tests.rsdocs/ARCHITECTURE.md-- updateloggingmodule description to reflect removalOBSERVABILITY.md-- replace stale "Log level and MCP client visibility" section; removenotifications/messageandlogging/setLevelreferencesTest plan
cargo clippy --locked --profile ci -- -D warnings)cargo fmt --check)#[allow(deprecated)]introducedCloses #1342