-
Notifications
You must be signed in to change notification settings - Fork 643
Adds flag to publish to allow clearing on migration conflict. #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bfops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my code-owned changes LGTM, but left several small comments
|
Fixed all the comments! |
Co-authored-by: Zeke Foppa <[email protected]> Signed-off-by: Tyler Cloutier <[email protected]>
18e60dc to
fab73cc
Compare
|
Smoketests failing due to: |
Co-authored-by: Zeke Foppa <[email protected]> Signed-off-by: Tyler Cloutier <[email protected]>
|
Disabling auto-merge since I was only approving my code-owned changes. |
bfops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the PR LGTM
Description of Changes
This PR modifies the
--delete-dataflag onspacetime publishand adds the--delete-dataflag onspacetime dev.In particular instead of
--delete-databeing a boolean, it is now a an enum:always-> corresponds to the old value oftruenever-> corresponds to the old value offalseon-conflict-> clears the database, but only if publishing would have required a manual migrationThis flag does NOT change any behavior about prompting users to confirm if they want to delete the data. Users will still be prompted to confirm UNLESS they pass the separate
--yesflag.spacetime devgets the same--delete-dataflag. The default value ofneveris equivalent to the existing behavior.spacetime devcontinues to publish with--yesjust as before. This behavior is unchanged.API and ABI breaking changes
Adds the flags specified above. This is NOT a breaking change to the CLI. Passing
--delete-datais the equivalent of--delete-data=always.This IS technically a breaking change to the
pre_publishroute. As far as I'm aware this is only used by our CLI however.Expected complexity level and risk
2, Very small change, but if we get it wrong users could accidentally lose data. I would ask reviewers to think about ways that users might accidentally pass
--delete-data --yes.Testing