Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at providing support for clj-kondo hooks in libpython-clj. For details on the specific hooks please see: clj-python/clj-template#9
The idea here is to bundle the hooks with libpython-clj itself so that users can obtain the relevant hook code from the library (whether it's via a
.jar
or a git dep) itself and not have to go looking elsewhere nor figure out which version of the hook code is appropriate.Note that getting the hook code into place and activated in one's project is a process that involves user intervention -- it is not just a matter of obtaining libpython-clj or updating a libpython-clj dependency.
The process subsequent to updating libpython-clj is basically:
.clj-kondo
directory in the project's top-level directory.clj-kondo
directory.clj-kondo/config.edn
appropriatelyThe following comment contains a log of this process for libpython-clj: clj-kondo/config#1 (comment) [1]
Documentation for this feature can be found at: https://github.com/borkdude/clj-kondo/blob/master/doc/config.md#Exporting-and-importing-configuration
Note that versions of clj-kondo earlier than v2020.11.07 are not likely to work.
[1] Slight gotcha with the instructions -- initially I used "clj_python" as a directory name, but was told this could be "clj-python". This change has been reflected in this PR.