Allow custom SslContext without ALPN again for HTTP/1.1-only case
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of HTTP/2 support, Aleph started to require a matching ALPN config to be present in custom `SslContext` objects. This needlessly broke existing HTTP/1.1-only uses. With this change, we now allow custom `SslContext` objects without ALPN config again if only HTTP/1.1 is desired (via the `http-versions` option). Since this still happens to be the default, existing uses should just work again. Fixes #727
arnaudgeiser
approved these changes
Jun 14, 2024
This is a mirror of `test-http-versions-server-config` to test various permutations of the `http-versions` option in combination with `ssl-context` and `force-h2c?`.
KingMob
reviewed
Jun 15, 2024
KingMob
reviewed
Jun 15, 2024
KingMob
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of HTTP/2 support, Aleph started to require a matching ALPN config to be present in custom
SslContextobjects. This needlessly broke existing HTTP/1.1-only uses. With this change, we now allow customSslContextobjects without ALPN config again if only HTTP/1.1 is desired (via thehttp-versionsoption). Since this still happens to be the default, existing uses should just work again.Fixes #727
@KingMob your suggested patch almost worked as-is but was thwarted by the fact that
applicationProtocolNegotiatoris always present (see code comment).Review welcome but don't merge, yet, as I also would like to add a
test-http-versions-client-configtest which mirrorstest-http-versions-server-configfor the client (as that's what #727 was originally about).