Skip to content

Feature/capgen-ng PR review changes - #6

Merged
climbfuji merged 3 commits into
climbfuji:feature/capgen-ngfrom
scrasmussen:feature/capgen-ng-review
Jul 13, 2026
Merged

Feature/capgen-ng PR review changes#6
climbfuji merged 3 commits into
climbfuji:feature/capgen-ngfrom
scrasmussen:feature/capgen-ng-review

Conversation

@scrasmussen

Copy link
Copy Markdown

Changes to PR NCAR#695 as part of my review. Figured they were big enough it was easier to create a PR

DESCRIPTION OF CHANGES:

  • CMakeLists.txt
    • End of line characters were ^M, indicating mixed Windows and Linux carriage returns, ran dos2unix on the file
    • another commit reduces Intel compile time optimization from default -O3 to -O2 and removes -qoverride-limits. These two changes reduce ifx -j4 compile time from 93 minutes to 2 min 8 sec.
  • suites that were removed also needed to be removed from suite_info.py
  • changed macros in scm.F90 and scm_time_integration.F90 to parameters. I though the macro additions came from a coding agent but if there is a reason to keep the macros I can remove them!

Comment thread scm/src/scm_time_integration.F90 Outdated
Comment thread scm/src/scm.F90 Outdated
@scrasmussen
scrasmussen force-pushed the feature/capgen-ng-review branch from 4fd54ad to 9da07fd Compare July 13, 2026 18:46

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much

@climbfuji
climbfuji merged commit 47db8cd into climbfuji:feature/capgen-ng Jul 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants