feat: Remove deprecated SDK props #7088
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacekradko
changed the title
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| type ClerkOptionsLegacyRedirectProps = { | ||
| /** | ||
| * @deprecated Use `signInFallbackRedirectUrl` or `signInForceRedirectUrl` instead. | ||
| */ | ||
| afterSignInUrl?: string | null; | ||
| /** | ||
| * @deprecated Use `signUpFallbackRedirectUrl` or `signUpForceRedirectUrl` instead. | ||
| */ | ||
| afterSignUpUrl?: string | null; | ||
| /** | ||
| * @deprecated Use `signInFallbackRedirectUrl`, `signInForceRedirectUrl`, `signUpFallbackRedirectUrl`, or `signUpForceRedirectUrl` instead. | ||
| */ | ||
| redirectUrl?: string | null; | ||
| }; |
There was a problem hiding this comment.
Doesn't this require a clerk-js major ? Are we doing that ?
There was a problem hiding this comment.
Yep. I can split the clerk-js specific changes to a separate PR in case we stay on v5.
Description
Removing deprecated props
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change