chore(clerk-js): Sort <PricingTable /> features #5528
Closed
+57
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
reviewed
Apr 4, 2025
| @@ -60,7 +60,7 @@ export function PricingTableMatrix({ | |||
| plans.forEach(({ features }) => { | |||
| features.forEach(({ name }) => featuresSet.add(name)); | |||
| }); | |||
| return Array.from(featuresSet); | |||
| return Array.from(featuresSet).sort((a, b) => a.localeCompare(b)); | |||
There was a problem hiding this comment.
I'd argue fapi should allow for sorting by name. But ignore my comment if you've already discussed this.
alexcarpenter
deleted the
alexcarpenter/com-323-sort-features-in-pricingtable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show plan features in alphabetical order
Resolves COM-323
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change