Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-react,astro,vue): Introduce treatPendingAsSignedOut prop to client control components #5512

Merged
merged 9 commits into from
Apr 3, 2025

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Apr 2, 2025

Description

Part of ORGS-621 - stacked on top of #5505 to not block development

Allows to pass treatPendingAsSignedOut per control component on client boundary:

<SignedOut>
  // Gets mounted without session or with a pending session 
   <SignIn />
</SignedOut>

--- 

<SignedOut treatPendingAsSignedOut={false}>
  // Gets mounted without session only 
   <SignIn />
</SignedOut>
<SignedIn>
  // Gets mounted for active session only
   <p>You have selected an organization!</p>
</SignedIn>

--- 

<SignedIn treatPendingAsSignedOut={false}>
   // Gets mounted for active session only
   <p>You have authenticated, but not might have selected an organization</p>
</SignedIn>
<Protect>
  // Gets mounted for active session only
   <p>You have selected an organization!</p>
</Protect>

--- 

<Protect treatPendingAsSignedOut={false}>
   // Gets mounted for active session only
   <p>You have authenticated, but not might have selected an organization</p>
</Protect>

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Apr 2, 2025
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: ddf0d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/astro Patch
@clerk/clerk-react Patch
@clerk/vue Patch
@clerk/chrome-extension Patch
@clerk/elements Patch
@clerk/clerk-expo Patch
@clerk/nextjs Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-react-start Patch
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 10:41pm

@LauraBeatris LauraBeatris requested a review from a team April 2, 2025 14:36
@LauraBeatris LauraBeatris marked this pull request as ready for review April 2, 2025 14:36
@LauraBeatris LauraBeatris force-pushed the laura/pending-use-auth branch from 396134b to ff18c63 Compare April 2, 2025 18:23
@LauraBeatris LauraBeatris force-pushed the laura/pending-client-control-components branch from f630e69 to 788bb33 Compare April 2, 2025 18:24
@LauraBeatris LauraBeatris force-pushed the laura/pending-use-auth branch 3 times, most recently from 55227d9 to f069ba7 Compare April 3, 2025 17:30
@LauraBeatris LauraBeatris force-pushed the laura/pending-client-control-components branch from 788bb33 to f21f0d0 Compare April 3, 2025 17:30
@LauraBeatris LauraBeatris force-pushed the laura/pending-use-auth branch 2 times, most recently from d44cf5f to 2950332 Compare April 3, 2025 21:20
Base automatically changed from laura/pending-use-auth to main April 3, 2025 21:31
@LauraBeatris LauraBeatris force-pushed the laura/pending-client-control-components branch from f21f0d0 to 8c00d3a Compare April 3, 2025 21:40
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Ship it! Pending those examples you called out 🚀

@LauraBeatris LauraBeatris force-pushed the laura/pending-client-control-components branch from e1002cb to ddf0d8c Compare April 3, 2025 22:40
@LauraBeatris LauraBeatris merged commit 026ad57 into main Apr 3, 2025
30 checks passed
@LauraBeatris LauraBeatris deleted the laura/pending-client-control-components branch April 3, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants