Skip to content

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Mar 21, 2025

Description

This PR introduces a change in the behavior introduced in #4720

Currently, we may end up rate-limited on phone number verification codes.

This PR addresses runs the signUp.create only when there is no ticket flow.
For all the other cases, we keep using signUp.upsert in order to not lose the ticket context.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

…ertain cases

When there is no ticket flow and a phone number is provided a new signUp attempt is used, in order to avoid rate-limiting issues with verification codes.
Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: b1188ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 5:56pm

@anagstef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.19-snapshot.v20250321172030
@clerk/clerk-js 5.57.2-snapshot.v20250321172030
@clerk/clerk-expo 2.9.2-snapshot.v20250321172030

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@anagstef anagstef changed the title fix(clerk-js): Use a new signUp attempt on SignUpStart component in certain cases fix(clerk-js): Use a new signUp attempt on SignUpStart component when there is no ticket flow Mar 21, 2025
@anagstef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.19-snapshot.v20250321173611
@clerk/clerk-js 5.57.2-snapshot.v20250321173611
@clerk/clerk-expo 2.9.2-snapshot.v20250321173611

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@anagstef anagstef self-assigned this Mar 21, 2025
@anagstef anagstef marked this pull request as ready for review March 21, 2025 17:51
@anagstef anagstef requested a review from octoper March 21, 2025 17:54
@anagstef anagstef merged commit 2dcaf65 into main Mar 21, 2025
30 checks passed
@anagstef anagstef deleted the stefanos/fraud-497-fix-signupstart-reusing-the-signup-attempt-on-phone-numbers branch March 21, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants