-
Notifications
You must be signed in to change notification settings - Fork 390
fix(clerk-js): Use a new signUp attempt on SignUpStart component when there is no ticket flow #5415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Use a new signUp attempt on SignUpStart component when there is no ticket flow #5415
Conversation
…ertain cases When there is no ticket flow and a phone number is provided a new signUp attempt is used, in order to avoid rate-limiting issues with verification codes.
🦋 Changeset detectedLatest commit: b1188ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
!snapshot |
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
!snapshot |
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
…he-signup-attempt-on-phone-numbers
Description
This PR introduces a change in the behavior introduced in #4720
Currently, we may end up rate-limited on phone number verification codes.
This PR addresses runs the
signUp.create
only when there is no ticket flow.For all the other cases, we keep using
signUp.upsert
in order to not lose the ticket context.Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change