Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nuxt): Re-export Vue components and composables #4750

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Dec 10, 2024

Description

Nuxt has auto-imports enabled by default. We are following that pattern but we also want to allow users to import it manually:

<script setup>
import { SignIn } from '@clerk/nuxt/components'
import { useAuth } from '@clerk/nuxt/composables' 

const { userId } = useAuth()
</script>

<template>
  <SignIn />
</template>

This PR adds export paths to enable manual imports.

Resolves ECO-276

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 80da979

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:01pm

@wobsoriano wobsoriano marked this pull request as ready for review December 11, 2024 16:59
@wobsoriano wobsoriano changed the title chore(nuxt): Re-export components and composables chore(nuxt): Re-export Vue components and composables Dec 11, 2024
@wobsoriano wobsoriano merged commit b34edd2 into main Dec 12, 2024
31 checks passed
@wobsoriano wobsoriano deleted the rob/eco-276-re-export-vue-sdk-components-and-composables-in-the-nuxt-sdk branch December 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants