Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Fix release workflow permissions #1914

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Oct 18, 2023

Description

The PR #1891 added permissions to the release workflow - and apparently they are not additive.

So this PR looks at https://github.com/clerkinc/javascript/actions/runs/6558834152/job/17813206786#step:1:16 and implements the needed stuff from it. (changesets/action#179 (comment))

@LekoArts LekoArts requested a review from a team as a code owner October 18, 2023 12:32
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: 723e1c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikosdouvlis nikosdouvlis merged commit a39d652 into main Oct 18, 2023
4 checks passed
@nikosdouvlis nikosdouvlis deleted the fix-release-workflow-permissions branch October 18, 2023 12:35
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants