refactor: Move logic to class

clerk · Dec 5, 2024 · bf3117f · bf3117f
1 parent 18af2b8
commit bf3117f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/clerk-js/src/core/resources/SignUp.ts b/packages/clerk-js/src/core/resources/SignUp.ts
@@ -367,6 +367,10 @@ export class SignUp extends BaseResource implements SignUpResource {
     });
   };
 
+  upsert = (params: SignUpCreateParams | SignUpUpdateParams): Promise<SignUpResource> => {
+    return this.id ? this.update(params) : this.create(params);
+  };
+
   validatePassword: ReturnType<typeof createValidatePassword> = (password, cb) => {
     if (SignUp.clerk.__unstable__environment?.userSettings.passwordSettings) {
       return createValidatePassword({

diff --git a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
@@ -232,10 +232,8 @@ function _SignUpStart(): JSX.Element {
     const redirectUrl = buildSSOCallbackURL(ctx, displayConfig.signUpUrl);
     const redirectUrlComplete = ctx.afterSignUpUrl || '/';
 
-    const requestParams = buildRequest(fieldsToSubmit);
-    const signUpRequest = signUp.id ? signUp.update(requestParams) : signUp.create(requestParams);
-
-    return signUpRequest
+    return signUp
+      .upsert(buildRequest(fieldsToSubmit))
       .then(res =>
         completeSignUpFlow({
           signUp: res,

diff --git a/packages/types/src/signUp.ts b/packages/types/src/signUp.ts
@@ -66,6 +66,8 @@ export interface SignUpResource extends ClerkResource {
 
   update: (params: SignUpUpdateParams) => Promise<SignUpResource>;
 
+  upsert: (params: SignUpCreateParams | SignUpUpdateParams) => Promise<SignUpResource>;
+
   prepareVerification: (params: PrepareVerificationParams) => Promise<SignUpResource>;
 
   attemptVerification: (params: AttemptVerificationParams) => Promise<SignUpResource>;