chore: refactor cache to use supplier #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalg0wda
commented
Oct 13, 2025
vishalg0wda
commented
- feat: add caching to JWKs
- chore: add skipjwkscache option
- refactor: improve JWKS cache readability with supplier pattern
vishalg0wda
force-pushed
the
subomi/feat/add-jwks-caching
branch
3 times, most recently
from
1d21595 to
8350f96
Compare
Refactored the cache-aside pattern in JwtSessionTokenVerifier to use a more declarative approach with a CheckedSupplier interface. The cache now transparently handles lookup and population through getOrCompute(), making the code more readable and maintainable. Changes: - Added CheckedSupplier functional interface for exception-safe suppliers - Updated Cache.getOrCompute() to accept CheckedSupplier for checked exceptions - Simplified getRemoteJwtKey() to use declarative cache-aside pattern - Removed manual cache checking and setting logic from fetchAndConvertJwk()
vishalg0wda
force-pushed
the
subomi/feat/add-jwks-caching
branch
from
8350f96 to
29aa1da
Compare
jescalan
approved these changes
Oct 15, 2025
| /** | ||
| * Retrieves the RSA public key used to sign the token from Clerk's Backend API. | ||
| * | ||
| * <p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.