-
Notifications
You must be signed in to change notification settings - Fork 3
Pre-built components #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
swolfand
wants to merge
191
commits into
main
Choose a base branch
from
sam/clerk-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pre-built components #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e8c550 to
f21f6eb
Compare
f7a765e to
b2496fd
Compare
d68c066 to
e836392
Compare
463cf8b to
0cb3c04
Compare
* update documentation and add extension functions * start building profile * add email section * add medium weight extension * start building phone row * start adding action handling * start adding add phone view * create UserProfilePhoneSection.kt.kt * start working in external account row * add UserProfileExternalAccountRow.kt * Add UserProfileExternalAccountSection.kt * add userprofile connected account section * update spacing * more spacing * add secured by clerk footer * add dark variant url * add remove exxternal account * add connected account bottom sheet * update clerk social row * integrate verify into bottom sheet * add email verification * create bottom sheet content * up through email verification no backup codes * up through email verification no backup codes * add backup codes view * pr review * fix test * update snapshots
* Start moving views to bottom sheet * move password to bottom sheet * start trying to add phone number * refactor * update user profile security view * update tests * add snapshots
* Add username to UserProfileAccountView Co-authored-by: sam <[email protected]> * update username --------- Co-authored-by: Cursor Agent <[email protected]>
* Refactor: Manage selected phone number state in parent composable Co-authored-by: sam <[email protected]> * Test: Assert loading and success states in code attempt tests Co-authored-by: sam <[email protected]> --------- Co-authored-by: Cursor Agent <[email protected]>
* update versions * start doing QA * more design feedback * more gutter fixing * more updates * add dismissing * change scrim * change scrim * animation * fix status bar * fix ripple * updates to phone row and menu * update shadow * cleanup * fix button * remove padding * update callbacks * more ui updates * fix verification and bottom sheet * update snapshots * update error state add phone number
|
❌ Paparazzi found snapshot diffs.
|
* fix errors * add explicit email and phone * handle requirements needed * update build * fix tests * update unit tests to parallel * update test runner
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* edit string * update pressed state for account button * add outline for avatarview * Update text style in avatar view for consistency * fix broken button and delete unused class * fix shadow * suppress lint * suppress lint * fix signin factor so that phone number is presented * update reset * updated shadows * disable autocomplete on password * update snapshots * resize on small screen * update code input field
|
❌ Paparazzi found snapshot diffs.
|
1 similar comment
|
❌ Paparazzi found snapshot diffs.
|
* remove clerk branding on non auth * remove clerk branding on non auth * make icons always the same size * update button text * remove progress indicator * stack when too small * add 12 dp padding * Update snapshots
* add new module * Add common main * add throttler * add android implementation * Add TelemetryTypes.kt * add TelemetryTypes.kt * Add TelemetryEvents.kt * Add interface for TelemetryEventThrottler.kt * Add AndroidTelemetryEventThrottler.kt * start adding TelemetryEnvironment.kt * add instance type * update environment * kdoc * Add commonMain collector * Add commonMain collector * integrate telemetry * update to ignore case
* Refactor: Pass ClerkTheme to components Pass ClerkTheme to components to allow for custom theming. Co-authored-by: sam <[email protected]> * spotless * update passkey rename view * always also check for a theme --------- Co-authored-by: Cursor Agent <[email protected]>
* add user button * add telemetry * pop show profile
* feat: Add ClerkTypographyDefaults for easier theming Co-authored-by: sam <[email protected]> * Add Compose BOM and foundation to test dependencies Co-authored-by: sam <[email protected]> * Checkpoint before follow-up message Co-authored-by: sam <[email protected]> * Refactor ClerkTypography to use defaults and nullable parameters Co-authored-by: sam <[email protected]> * formatting * update snapshots --------- Co-authored-by: Cursor Agent <[email protected]>
* Refactor: Allow passing ClerkTheme to composables Co-authored-by: sam <[email protected]> * Expose clerk typography defaults for customization (#374) * feat: Add ClerkTypographyDefaults for easier theming Co-authored-by: sam <[email protected]> * Add Compose BOM and foundation to test dependencies Co-authored-by: sam <[email protected]> * Checkpoint before follow-up message Co-authored-by: sam <[email protected]> * Refactor ClerkTypography to use defaults and nullable parameters Co-authored-by: sam <[email protected]> * formatting * update snapshots --------- Co-authored-by: Cursor Agent <[email protected]> * make image service internal * spotless * update theme override * fix moving authstate * fix moving authstate * fix moving authstate * update baseline * Fix: Inherit parent theme when ClerkTheme is null Co-authored-by: sam <[email protected]> * remove on auth complete * update to theme * Refactor: Pass ClerkTheme directly to ClerkMaterialTheme Co-authored-by: sam <[email protected]> * Refactor ClerkThemeOverrideProvider to conditionally provide theme Co-authored-by: sam <[email protected]> * Refactor ClerkThemeOverrideProvider to use parent theme Co-authored-by: sam <[email protected]> * remove theme --------- Co-authored-by: Cursor Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for pre-built components.
Note: this isn't getting merged until it's completely done since we don't want upstream consumers of the API SDK to get ui components before they're ready